Re: [Qemu-devel] [PATCH] trace: drop trailing empty strings

[Stefan Hajnoczi <stefanha@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

On Mon, Jan 18, 2016 at 07:28:43PM +0100, Greg Kurz wrote:
> On Mon, 18 Jan 2016 20:37:58 +0300
> Michael Tokarev <mjt@tls.msk.ru> wrote:
> 
> > 11.01.2016 20:30, Greg Kurz wrote:
> > 
> > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64""
> > > +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section name: %s gpa: %"PRIx64  
> > ...
> > 
> > I'm not sure what's the value of this.  It's fine either way, no?
> 
> The only value is to drop unneeded stuff... and maybe some consistency
> with the traces that don't have these trailing empty strings.
> 
> > Do we have a rule for trailing empty strings in coding style? :)
> > 
> 
> Nor we have against parenthesitis, which brings a lot more unneeded
> characters into the code :P

Regarding the history of the quoting limitation, see commit
cf85cf8e972f3ad79f203be4edb7968d6e052293 ("trace: Format strings must
begin/end with double quotes").  It was a limitation of the old
tracetool.sh script.

The modern tracetool.py script handles format strings fine when they do
not end with double-quotes.

Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]