From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49220)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=hGjI=OI=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1aTFbq-0001JQ-OD
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 16:14:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from
	<SRS0=hGjI=OI=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1aTFbn-0001S3-HB
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 16:14:06 -0500
Received: from sonata.ens-lyon.org ([140.77.166.138]:36304)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from
	<SRS0=hGjI=OI=ens-lyon.org=samuel.thibault@bounce.ens-lyon.org>)
	id 1aTFbn-0001Rz-AV
	for qemu-devel@nongnu.org; Tue, 09 Feb 2016 16:14:03 -0500
Date: Tue, 9 Feb 2016 22:13:59 +0100
From: Samuel Thibault <samuel.thibault@gnu.org>
Message-ID: <20160209211359.GK2673@var.home>
References: <cover.1454927009.git.samuel.thibault@ens-lyon.org>
	<e4a16e2d4a3d7cd589639222c0414d265ed41226.1454927009.git.samuel.thibault@ens-lyon.org>
	<56BA4FA2.1070809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56BA4FA2.1070809@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv7 3/9] slirp: Adding IPv6 UDP support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>, Li Zhijian <lizhijian@cn.fujitsu.com>, Stefan Hajnoczi <stefanha@gmail.com>, Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org, Vasiliy Tolstov <v.tolstov@selfip.ru>, Dave Gilbert <dgilbert@redhat.com>, Gonglei <arei.gonglei@huawei.com>, Jan Kiszka <jan.kiszka@siemens.com>, Huangpeng <peter.huangpeng@huawei.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Guillaume Subiron <maethor@subiron.org>

Thomas Huth, on Tue 09 Feb 2016 21:44:18 +0100, wrote:
> > +	    case AF_INET6:
> > +	        udp6_output(so, m, (struct sockaddr_in6 *) &saddr,
> > +	                    (struct sockaddr_in6 *) &daddr);
> > +	        break;
> >  	    default:
> > +	        g_assert_not_reached();
> 
> Could this be triggered by the guest?

No, here we are in sorecvfrom, which only reads ipv4 or ipv6 packets
from the udp socket.

> > +    so->so_ffamily = AF_INET6;
> > +    so->so_faddr6 = ip->ip_dst; /* XXX */
> > +    so->so_fport6 = uh->uh_dport; /* XXX */
> 
> Why use the XXXs here? Some additional words in the comments would be
> nice...

That's a copy/paste from the UDPv4 code.  I don't know why they are there.

Samuel