From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTWhM-00006G-2e for qemu-devel@nongnu.org; Wed, 10 Feb 2016 10:29:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aTWhH-0000Ah-U6 for qemu-devel@nongnu.org; Wed, 10 Feb 2016 10:28:55 -0500 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:33782) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aTWhH-00009R-JB for qemu-devel@nongnu.org; Wed, 10 Feb 2016 10:28:51 -0500 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 10 Feb 2016 15:28:48 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id BC2FC1B08074 for ; Wed, 10 Feb 2016 15:28:58 +0000 (GMT) Received: from d06av10.portsmouth.uk.ibm.com (d06av10.portsmouth.uk.ibm.com [9.149.37.251]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1AFSiG363176842 for ; Wed, 10 Feb 2016 15:28:44 GMT Received: from d06av10.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av10.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1AESksg031449 for ; Wed, 10 Feb 2016 07:28:46 -0700 Date: Wed, 10 Feb 2016 16:28:43 +0100 From: David Hildenbrand Message-ID: <20160210162843.3315d423@thinkpad-w530> In-Reply-To: <1453913621-20961-1-git-send-email-mjrosato@linux.vnet.ibm.com> References: <1453913621-20961-1-git-send-email-mjrosato@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 00/10] Allow hotplug of s390 CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Matthew Rosato Cc: qemu-devel@nongnu.org, agraf@suse.de, borntraeger@de.ibm.com, bharata@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net > Changes from v2->v3: > > * Call cpu_remove_sync rather than cpu_remove(). > * Pull latest version of patches from pseries set (v6). Trivial change to > "Reclaim VCPU objects" to fix checkpatch error. > * Add object_unparent during s390_cpu_release to accomodate changes in > Patch 4 "Reclaim VCPU objects." > * Remove a cleanup patch in favor of 2 patches from pseries set. > > ************** > > The following patchset enables hotplug of s390 CPUs. > > The standard interface is used -- to configure a guest with 2 CPUs online at > boot and 4 maximum: > > qemu -smp 2,maxcpus=4 > > To subsequently hotplug a CPU: > > Issue 'device_add s390-cpu,id=' from monitor. (questions for the bigger audience) For x86, cpu models are realized by making x86_64-cpu an abstract class and creating loads of new classes, e.g. host-x86_64-cpu or haswell-x86_64-cpu. How does 'device_add ' play together with the x86 cpu model approach? And with cpu models specified via "-cpu" in general? Or does that in return mean, that "making models own classes" is outdated? Or will some internal conversion happen that I am missing? What is the plan for cpu models and cpu hotplug? How are cpu models to be defined in the future? David