From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46719)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1aTYnu-00034K-E6
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 12:43:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1aTYnp-0005av-Bb
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 12:43:50 -0500
Received: from e17.ny.us.ibm.com ([129.33.205.207]:34514)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mdroth@linux.vnet.ibm.com>) id 1aTYnp-0005aV-65
	for qemu-devel@nongnu.org; Wed, 10 Feb 2016 12:43:45 -0500
Received: from localhost
	by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only!
	Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <mdroth@linux.vnet.ibm.com>;
	Wed, 10 Feb 2016 12:43:44 -0500
Received: from b01cxnp22035.gho.pok.ibm.com (b01cxnp22035.gho.pok.ibm.com
	[9.57.198.25])
	by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 3B05638C805E
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2016 12:43:41 -0500 (EST)
Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215])
	by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id
	u1AHhf1r33685670
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2016 17:43:41 GMT
Received: from d01av01.pok.ibm.com (localhost [127.0.0.1])
	by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	u1AHhegC026448
	for <qemu-devel@nongnu.org>; Wed, 10 Feb 2016 12:43:40 -0500
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
From: Michael Roth <mdroth@linux.vnet.ibm.com>
In-Reply-To: <1452503561-29521-1-git-send-email-leonid@daynix.com>
References: <1452503561-29521-1-git-send-email-leonid@daynix.com>
Message-ID: <20160210174332.7987.54737@loki>
Date: Wed, 10 Feb 2016 11:43:32 -0600
Subject: Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leonid Bloch <leonid@daynix.com>, qemu-devel@nongnu.org
Cc: Yan Vugenfirer <yan@daynix.com>

Quoting Leonid Bloch (2016-01-11 03:12:41)
> With automatically generated GUID, on minor version changes, an error
> occurred, stating that there is a problem with the installer.
> Now, a notification is shown, warning the user that another version of
> this product is already installed, and that configuration or removal of
> the existing version is possible through Add/Remove Programs on the
> Control Panel (expected behavior).
> =

> Signed-off-by: Leonid Bloch <leonid@daynix.com>

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>

> ---
>  qga/installer/qemu-ga.wxs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> =

> diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> index 9473875..7f92891 100644
> --- a/qga/installer/qemu-ga.wxs
> +++ b/qga/installer/qemu-ga.wxs
> @@ -41,7 +41,7 @@
> =

>    <Product
>      Name=3D"QEMU guest agent"
> -    Id=3D"*"
> +    Id=3D"{DF9974AD-E41A-4304-81AD-69AA8F299766}"
>      UpgradeCode=3D"{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
>      Manufacturer=3D"$(env.QEMU_GA_MANUFACTURER)"
>      Version=3D"$(env.QEMU_GA_VERSION)"
> -- =

> 2.4.3
>=20