* [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
@ 2016-01-11 9:12 Leonid Bloch
2016-01-31 14:18 ` Leonid Bloch
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Leonid Bloch @ 2016-01-11 9:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Yan Vugenfirer, Michael Roth
With automatically generated GUID, on minor version changes, an error
occurred, stating that there is a problem with the installer.
Now, a notification is shown, warning the user that another version of
this product is already installed, and that configuration or removal of
the existing version is possible through Add/Remove Programs on the
Control Panel (expected behavior).
Signed-off-by: Leonid Bloch <leonid@daynix.com>
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
index 9473875..7f92891 100644
--- a/qga/installer/qemu-ga.wxs
+++ b/qga/installer/qemu-ga.wxs
@@ -41,7 +41,7 @@
<Product
Name="QEMU guest agent"
- Id="*"
+ Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}"
UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
Version="$(env.QEMU_GA_VERSION)"
--
2.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
2016-01-11 9:12 [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue Leonid Bloch
@ 2016-01-31 14:18 ` Leonid Bloch
2016-02-10 17:43 ` Michael Roth
2016-02-25 2:07 ` Michael Roth
2 siblings, 0 replies; 5+ messages in thread
From: Leonid Bloch @ 2016-01-31 14:18 UTC (permalink / raw)
To: QEMU; +Cc: Yan Vugenfirer, Michael Roth
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
ping
http://patchwork.ozlabs.org/patch/565712
On Mon, Jan 11, 2016 at 11:12 AM, Leonid Bloch <leonid@daynix.com> wrote:
> With automatically generated GUID, on minor version changes, an error
> occurred, stating that there is a problem with the installer.
> Now, a notification is shown, warning the user that another version of
> this product is already installed, and that configuration or removal of
> the existing version is possible through Add/Remove Programs on the
> Control Panel (expected behavior).
>
> Signed-off-by: Leonid Bloch <leonid@daynix.com>
> ---
> qga/installer/qemu-ga.wxs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> index 9473875..7f92891 100644
> --- a/qga/installer/qemu-ga.wxs
> +++ b/qga/installer/qemu-ga.wxs
> @@ -41,7 +41,7 @@
>
> <Product
> Name="QEMU guest agent"
> - Id="*"
> + Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}"
> UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
> Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
> Version="$(env.QEMU_GA_VERSION)"
> --
> 2.4.3
>
>
[-- Attachment #2: Type: text/html, Size: 1754 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
2016-01-11 9:12 [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue Leonid Bloch
2016-01-31 14:18 ` Leonid Bloch
@ 2016-02-10 17:43 ` Michael Roth
2016-02-25 2:07 ` Michael Roth
2 siblings, 0 replies; 5+ messages in thread
From: Michael Roth @ 2016-02-10 17:43 UTC (permalink / raw)
To: Leonid Bloch, qemu-devel; +Cc: Yan Vugenfirer
Quoting Leonid Bloch (2016-01-11 03:12:41)
> With automatically generated GUID, on minor version changes, an error
> occurred, stating that there is a problem with the installer.
> Now, a notification is shown, warning the user that another version of
> this product is already installed, and that configuration or removal of
> the existing version is possible through Add/Remove Programs on the
> Control Panel (expected behavior).
>
> Signed-off-by: Leonid Bloch <leonid@daynix.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> qga/installer/qemu-ga.wxs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> index 9473875..7f92891 100644
> --- a/qga/installer/qemu-ga.wxs
> +++ b/qga/installer/qemu-ga.wxs
> @@ -41,7 +41,7 @@
>
> <Product
> Name="QEMU guest agent"
> - Id="*"
> + Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}"
> UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
> Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
> Version="$(env.QEMU_GA_VERSION)"
> --
> 2.4.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
2016-01-11 9:12 [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue Leonid Bloch
2016-01-31 14:18 ` Leonid Bloch
2016-02-10 17:43 ` Michael Roth
@ 2016-02-25 2:07 ` Michael Roth
2016-02-25 8:15 ` Leonid Bloch
2 siblings, 1 reply; 5+ messages in thread
From: Michael Roth @ 2016-02-25 2:07 UTC (permalink / raw)
To: Leonid Bloch, qemu-devel; +Cc: Yan Vugenfirer
Quoting Leonid Bloch (2016-01-11 03:12:41)
> With automatically generated GUID, on minor version changes, an error
> occurred, stating that there is a problem with the installer.
> Now, a notification is shown, warning the user that another version of
> this product is already installed, and that configuration or removal of
> the existing version is possible through Add/Remove Programs on the
> Control Panel (expected behavior).
>
> Signed-off-by: Leonid Bloch <leonid@daynix.com>
Thanks, applied to qga tree:
https://github.com/mdroth/qemu/commits/qga
> ---
> qga/installer/qemu-ga.wxs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> index 9473875..7f92891 100644
> --- a/qga/installer/qemu-ga.wxs
> +++ b/qga/installer/qemu-ga.wxs
> @@ -41,7 +41,7 @@
>
> <Product
> Name="QEMU guest agent"
> - Id="*"
> + Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}"
> UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
> Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
> Version="$(env.QEMU_GA_VERSION)"
> --
> 2.4.3
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue
2016-02-25 2:07 ` Michael Roth
@ 2016-02-25 8:15 ` Leonid Bloch
0 siblings, 0 replies; 5+ messages in thread
From: Leonid Bloch @ 2016-02-25 8:15 UTC (permalink / raw)
To: Michael Roth; +Cc: Yan Vugenfirer, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Feb 25, 2016 4:09 AM, "Michael Roth" <mdroth@linux.vnet.ibm.com> wrote:
>
> Quoting Leonid Bloch (2016-01-11 03:12:41)
> > With automatically generated GUID, on minor version changes, an error
> > occurred, stating that there is a problem with the installer.
> > Now, a notification is shown, warning the user that another version of
> > this product is already installed, and that configuration or removal of
> > the existing version is possible through Add/Remove Programs on the
> > Control Panel (expected behavior).
> >
> > Signed-off-by: Leonid Bloch <leonid@daynix.com>
>
> Thanks, applied to qga tree:
>
> https://github.com/mdroth/qemu/commits/qga
Thanks, Michael.
>
> > ---
> > qga/installer/qemu-ga.wxs | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/qga/installer/qemu-ga.wxs b/qga/installer/qemu-ga.wxs
> > index 9473875..7f92891 100644
> > --- a/qga/installer/qemu-ga.wxs
> > +++ b/qga/installer/qemu-ga.wxs
> > @@ -41,7 +41,7 @@
> >
> > <Product
> > Name="QEMU guest agent"
> > - Id="*"
> > + Id="{DF9974AD-E41A-4304-81AD-69AA8F299766}"
> > UpgradeCode="{EB6B8302-C06E-4BEC-ADAC-932C68A3A98D}"
> > Manufacturer="$(env.QEMU_GA_MANUFACTURER)"
> > Version="$(env.QEMU_GA_VERSION)"
> > --
> > 2.4.3
> >
>
[-- Attachment #2: Type: text/html, Size: 1928 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-02-25 8:15 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-11 9:12 [Qemu-devel] [PATCH] qemu-ga: Fixed minor version switch issue Leonid Bloch
2016-01-31 14:18 ` Leonid Bloch
2016-02-10 17:43 ` Michael Roth
2016-02-25 2:07 ` Michael Roth
2016-02-25 8:15 ` Leonid Bloch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).