From: Fam Zheng <famz@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: kwolf@redhat.com, jcody@redhat.com, stefanha@redhat.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable
Date: Sun, 14 Feb 2016 14:46:13 +0800 [thread overview]
Message-ID: <20160214064613.GA31933@ad.usersys.redhat.com> (raw)
In-Reply-To: <1455318392-26765-2-git-send-email-jsnow@redhat.com>
On Fri, 02/12 18:06, John Snow wrote:
> typedef struct CowRequest {
> @@ -46,6 +43,8 @@ typedef struct BackupBlockJob {
> CoRwlock flush_rwlock;
> uint64_t sectors_read;
> HBitmap *bitmap;
> + int64_t cluster_size;
> + int64_t sectors_per_cluster;
I don't think it makes sense to duplicate one value in two units.
Fam
next prev parent reply other threads:[~2016-02-14 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 23:06 [Qemu-devel] [PATCH 0/3] blockjob: correct backup cluster size for incremental backups John Snow
2016-02-12 23:06 ` [Qemu-devel] [PATCH 1/3] block/backup: make backup cluster size configurable John Snow
2016-02-14 6:46 ` Fam Zheng [this message]
2016-02-16 13:38 ` John Snow
2016-02-12 23:06 ` [Qemu-devel] [PATCH 2/3] block/backup: avoid copying less than full target clusters John Snow
2016-02-14 6:49 ` Fam Zheng
2016-02-16 15:43 ` John Snow
2016-02-12 23:06 ` [Qemu-devel] [PATCH 3/3] iotests/124: Add cluster_size mismatch test John Snow
2016-02-14 7:08 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160214064613.GA31933@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).