From: Fam Zheng <famz@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Wei Huang <wei@redhat.com>,
drjones@redhat.com, libvir-list@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com, abologna@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version
Date: Mon, 15 Feb 2016 15:49:57 +0800 [thread overview]
Message-ID: <20160215074957.GB3409@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160215073443.GA7978@pxdev.xzpeter.org>
On Mon, 02/15 15:34, Peter Xu wrote:
> On Mon, Feb 15, 2016 at 12:54:57AM -0600, Wei Huang wrote:
> > On 2/13/16 23:41, Peter Xu wrote:
> > > One question: how should I make this command "ARM only"? I see that
> > > in qmp-commands.hx, I can use something like "#if defined
> > > TARGET_ARM" to block out ARM specified commands, however how should
> > > I do the similiar thing in qapi-schema.json?
> >
> > This situation is similar to "rtc-reset-reinjection", right? I think You
> > can disable this feature on other arch's by setting
> > QERR_FEATURE_DISABLED in file like monitor.c.
>
> Yes. Will include this when post the real patches.
Yes, I think returning an error for non-ARM targets suffices.
Fam
next prev parent reply other threads:[~2016-02-15 7:50 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 5:41 [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version Peter Xu
2016-02-14 5:41 ` [Qemu-devel] [RFC PATCH 1/2] arm: gic: add GICType Peter Xu
2016-02-14 5:41 ` [Qemu-devel] [RFC PATCH 2/2] arm: gic: add "query-gic-capability" interface Peter Xu
2016-02-15 6:54 ` [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC version Wei Huang
2016-02-15 7:34 ` Peter Xu
2016-02-15 7:49 ` Fam Zheng [this message]
2016-02-15 9:35 ` [Qemu-devel] [libvirt] " Martin Kletzander
2016-02-15 9:41 ` Peter Maydell
2016-02-15 12:16 ` Andrew Jones
2016-02-15 12:27 ` Pavel Fedin
2016-02-15 10:09 ` Peter Xu
2016-02-15 9:52 ` [Qemu-devel] " Markus Armbruster
2016-02-15 10:34 ` Peter Xu
2016-02-15 15:08 ` Markus Armbruster
2016-02-15 15:21 ` Peter Maydell
2016-02-15 19:40 ` Markus Armbruster
2016-02-15 20:18 ` Andrew Jones
2016-02-15 20:32 ` Peter Maydell
2016-02-16 10:10 ` Markus Armbruster
2016-02-16 10:15 ` Daniel P. Berrange
2016-02-16 12:05 ` [Qemu-devel] [libvirt] " Andrea Bolognani
2016-02-16 12:09 ` Peter Maydell
2016-02-16 12:20 ` Andrea Bolognani
2016-02-16 12:15 ` Daniel P. Berrange
2016-02-16 12:27 ` Andrea Bolognani
2016-02-16 12:38 ` Daniel P. Berrange
2016-02-16 13:14 ` Andrea Bolognani
2016-02-15 15:22 ` [Qemu-devel] " Daniel P. Berrange
2016-02-18 4:40 ` Peter Xu
2016-02-18 16:52 ` Andrew Jones
2016-02-18 17:10 ` Andrea Bolognani
2016-02-19 1:55 ` Peter Xu
2016-02-19 12:33 ` Andrea Bolognani
2016-02-22 1:35 ` Peter Xu
2016-02-29 16:30 ` Andrea Bolognani
2016-03-01 2:19 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215074957.GB3409@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=abologna@redhat.com \
--cc=armbru@redhat.com \
--cc=drjones@redhat.com \
--cc=libvir-list@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).