From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38169)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aVDv6-0001Aq-Vw
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 02:50:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aVDv1-0002SE-6V
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 02:50:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54843)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aVDv1-0002Rw-1B
	for qemu-devel@nongnu.org; Mon, 15 Feb 2016 02:50:03 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 18EA32FB8B1
	for <qemu-devel@nongnu.org>; Mon, 15 Feb 2016 07:50:02 +0000 (UTC)
Date: Mon, 15 Feb 2016 15:49:57 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160215074957.GB3409@ad.usersys.redhat.com>
References: <1455428503-2113-1-git-send-email-peterx@redhat.com>
	<56C17641.5090208@redhat.com>
	<20160215073443.GA7978@pxdev.xzpeter.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160215073443.GA7978@pxdev.xzpeter.org>
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] ARM: add QMP command to query GIC
 version
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: Wei Huang <wei@redhat.com>, drjones@redhat.com, libvir-list@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, abologna@redhat.com

On Mon, 02/15 15:34, Peter Xu wrote:
> On Mon, Feb 15, 2016 at 12:54:57AM -0600, Wei Huang wrote:
> > On 2/13/16 23:41, Peter Xu wrote:
> > > One question: how should I make this command "ARM only"? I see that
> > > in qmp-commands.hx, I can use something like "#if defined
> > > TARGET_ARM" to block out ARM specified commands, however how should
> > > I do the similiar thing in qapi-schema.json?
> > 
> > This situation is similar to "rtc-reset-reinjection", right? I think You
> > can disable this feature on other arch's by setting
> > QERR_FEATURE_DISABLED in file like monitor.c.
> 
> Yes. Will include this when post the real patches.

Yes, I think returning an error for non-ARM targets suffices.

Fam