From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42027) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVHMp-0001kM-Et for qemu-devel@nongnu.org; Mon, 15 Feb 2016 06:31:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVHMk-0004kp-Ax for qemu-devel@nongnu.org; Mon, 15 Feb 2016 06:30:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48042) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVHMj-0004kg-Sl for qemu-devel@nongnu.org; Mon, 15 Feb 2016 06:30:54 -0500 Date: Mon, 15 Feb 2016 13:30:49 +0200 From: "Michael S. Tsirkin" Message-ID: <20160215132645-mutt-send-email-mst@redhat.com> References: <1454840944-29299-1-git-send-email-mst@redhat.com> <1454840944-29299-3-git-send-email-mst@redhat.com> <1455533904.7504.23.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455533904.7504.23.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/4] pc/q35: drop compatiility with old bios types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Eduardo Habkost , Marcel Apfelbaum , John Snow , Markus Armbruster , qemu-devel@nongnu.org, Paolo Bonzini , Igor Mammedov , Laszlo Ersek , Richard Henderson On Mon, Feb 15, 2016 at 11:58:24AM +0100, Gerd Hoffmann wrote: > On So, 2016-02-07 at 12:29 +0200, Michael S. Tsirkin wrote: > > We don't ship bios without support for loading ACPI anymore, and old q35 > > machine types don't allow migrating such bios. Drop it, as well as > > has_*mr flags that are there for migration compatibility. > > Wouldn't that break migration between 2.5 and 2.6 with -M q35-1.6 ? I think I said this somewhere but I'll repeat it here: I think we should just mark the old machine types non migrateable. > It's also a guest-visible change as acpi tables change ... acpi tables change yes but not too much - there are just bugfixes. We change acpi tables without versioning within reason. For example, recent change by Igor completely removed SSDT and affected old machine types too. > I'm all for cleaning up this old cruft, but I think it would be cleaner > to just drop the old (pre-migration support) q35 machine types instead > of changing them in subtle ways ... > > cheers, > Gerd Easier, sure. Not sure about the cleaner ... -- MST