From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43069) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVJE8-0005wr-Iy for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:30:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVJE5-0007R2-9Q for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:30:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48633) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVJE5-0007Q4-42 for qemu-devel@nongnu.org; Mon, 15 Feb 2016 08:30:05 -0500 Date: Mon, 15 Feb 2016 21:29:59 +0800 From: Fam Zheng Message-ID: <20160215132959.GA18222@ad.usersys.redhat.com> References: <1454664263-25969-1-git-send-email-famz@redhat.com> <1454664263-25969-5-git-send-email-famz@redhat.com> <878u2mnsyw.fsf@linaro.org> <8760xqnnvd.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <8760xqnnvd.fsf@linaro.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 04/12] docker: Add test runner List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex =?iso-8859-1?Q?Benn=E9e?= Cc: kwolf@redhat.com, peter.maydell@linaro.org, sw@weilnetz.de, qemu-devel@nongnu.org, stefanha@redhat.com, Paolo Bonzini , jsnow@redhat.com, david@gibson.dropbear.id.au On Mon, 02/15 12:45, Alex Benn=E9e wrote: >=20 > Alex Benn=E9e writes: >=20 > > Fam Zheng writes: > > > >> It's better to have a launcher for all tests, to make it easier to > >> initialize and manage the environment. > >> > >> Signed-off-by: Fam Zheng > >> --- > >> tests/docker/run | 23 +++++++++++++++++++++++ > >> 1 file changed, 23 insertions(+) > >> create mode 100755 tests/docker/run > >> > >> diff --git a/tests/docker/run b/tests/docker/run > >> new file mode 100755 > >> index 0000000..739ecf9 > >> --- /dev/null > >> +++ b/tests/docker/run > >> @@ -0,0 +1,23 @@ > >> +#!/bin/bash -e > >> +# > >> +# Docker test runner > >> +# > >> +# Copyright (c) 2016 Red Hat Inc. > >> +# > >> +# Authors: > >> +# Fam Zheng > >> +# > >> +# This work is licensed under the terms of the GNU GPL, version 2 > >> +# or (at your option) any later version. See the COPYING file in > >> +# the top-level directory. > >> + > >> +# Prepare the environment > >> +. /etc/profile || true > >> +export PATH=3D/usr/lib/ccache:$PATH > >> + > >> +tmp=3D$QEMU_SRC > >> +QEMU_SRC=3D/var/tmp/qemu.tmp > >> +cp -r $tmp $QEMU_SRC > > > > The first time I ran the fedora target it seems to hang, the second t= ime > > with V=3D1 it reported my source tree was an in-tree build. > > > > Could we perhaps use git-archive to grab a pristine copy of the tree? > > Something like: > > > > STATUS=3D`git stash create` > > git archive -1 ${STATUS} -o ${TAR} > > > > Would give a clean source tree with current unstaged/uncommited files= . > > Unfortunately this wouldn't include new files yet to be committed in = any > > form to the source tree but using git stash save -u might include a > > bunch of unwanted stuff. >=20 > OK that won't work if you have alternates in your git setup. It seems t= o > me the creation of the pristine tree for docker should be done before w= e > enter the docker environment. >=20 > There is a slight wrinkle as to what happens if the user wants to enter > an interactive session for debugging. However that doesn't seem possibl= e > via the makefile and perhaps that is just as well. Perhaps that should > be a helper script for the user? We can use "make distclean" in the copied tree. Fam