From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVZJs-0000H8-HH for qemu-devel@nongnu.org; Tue, 16 Feb 2016 01:41:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVZJo-0000AP-Cd for qemu-devel@nongnu.org; Tue, 16 Feb 2016 01:41:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38576) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVZJo-0000A3-6g for qemu-devel@nongnu.org; Tue, 16 Feb 2016 01:41:04 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id BB87E80508 for ; Tue, 16 Feb 2016 06:41:03 +0000 (UTC) Date: Tue, 16 Feb 2016 14:40:59 +0800 From: Fam Zheng Message-ID: <20160216064059.GF18664@ad.usersys.redhat.com> References: <1449628943-10197-1-git-send-email-peterx@redhat.com> <1449628943-10197-10-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449628943-10197-10-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 09/11] Dump: add qmp command "query-dump" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: drjones@redhat.com, lersek@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, lcapitulino@redhat.com On Wed, 12/09 10:42, Peter Xu wrote: > - s->status = (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED); > - error_propagate(errp, local_err); This means the error is released by caller, ... > + /* make sure status is written after written_size updates */ > + smp_wmb(); > + atomic_set(&s->status, > + (local_err ? DUMP_STATUS_FAILED : DUMP_STATUS_COMPLETED)); but it is removed now. Is local_err leaked now? Fam