From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56518) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVZvu-0000XV-Ox for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:20:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVZvp-0007Yw-Pp for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:20:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44469) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVZvp-0007Ys-Jt for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:20:21 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 4810F8DFE0 for ; Tue, 16 Feb 2016 07:20:21 +0000 (UTC) Date: Tue, 16 Feb 2016 15:20:17 +0800 From: Fam Zheng Message-ID: <20160216072017.GK18664@ad.usersys.redhat.com> References: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> <1455470231-5223-4-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455470231-5223-4-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/8] virtio: add AioContext-specific function for host notifiers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On Sun, 02/14 18:17, Paolo Bonzini wrote: > This is used to register ioeventfd with a dataplane thread. > > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 16 ++++++++++++++++ > include/hw/virtio/virtio.h | 2 ++ > 2 files changed, 18 insertions(+) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 90f2545..3a5cca4 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -1785,6 +1785,22 @@ static void virtio_queue_host_notifier_read(EventNotifier *n) > } > } > > +void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx, > + bool assign, bool set_handler) > +{ > + if (assign && set_handler) { > + aio_set_event_notifier(ctx, &vq->host_notifier, true, > + virtio_queue_host_notifier_read); > + } else { > + aio_set_event_notifier(ctx, &vq->host_notifier, true, NULL); > + } > + if (!assign) { > + /* Test and clear notifier before after disabling event, Does "before after" mean "after"? :) Reviewed-by: Fam Zheng > + * in case poll callback didn't have time to run. */ > + virtio_queue_host_notifier_read(&vq->host_notifier); > + } > +} > + > void virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign, > bool set_handler) > { > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 108cdb0..4ce01a1 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -248,6 +248,8 @@ void virtio_queue_set_guest_notifier_fd_handler(VirtQueue *vq, bool assign, > EventNotifier *virtio_queue_get_host_notifier(VirtQueue *vq); > void virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign, > bool set_handler); > +void virtio_queue_aio_set_host_notifier_handler(VirtQueue *vq, AioContext *ctx, > + bool assign, bool set_handler); > void virtio_queue_notify_vq(VirtQueue *vq); > void virtio_irq(VirtQueue *vq); > VirtQueue *virtio_vector_first_queue(VirtIODevice *vdev, uint16_t vector); > -- > 1.8.3.1 > > >