From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVZwc-0001EE-UO for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:21:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVZwX-0007kW-Up for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:21:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVZwX-0007kA-Q6 for qemu-devel@nongnu.org; Tue, 16 Feb 2016 02:21:05 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 8376DC0C236F for ; Tue, 16 Feb 2016 07:21:05 +0000 (UTC) Date: Tue, 16 Feb 2016 15:21:03 +0800 From: Fam Zheng Message-ID: <20160216072103.GL18664@ad.usersys.redhat.com> References: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> <1455470231-5223-5-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455470231-5223-5-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 4/8] virtio: export vring_notify as virtio_should_notify List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On Sun, 02/14 18:17, Paolo Bonzini wrote: > Virtio dataplane needs to trigger the irq manually through the > guest notifier. Export virtio_should_notify so that it can be > used around event_notifier_set. > > Signed-off-by: Paolo Bonzini > --- > hw/virtio/virtio.c | 4 ++-- > include/hw/virtio/virtio.h | 1 + > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > index 3a5cca4..abb97f4 100644 > --- a/hw/virtio/virtio.c > +++ b/hw/virtio/virtio.c > @@ -1162,7 +1162,7 @@ void virtio_irq(VirtQueue *vq) > virtio_notify_vector(vq->vdev, vq->vector); > } > > -static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq) > +bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq) > { > uint16_t old, new; > bool v; > @@ -1187,7 +1187,7 @@ static bool vring_notify(VirtIODevice *vdev, VirtQueue *vq) > > void virtio_notify(VirtIODevice *vdev, VirtQueue *vq) > { > - if (!vring_notify(vdev, vq)) { > + if (!virtio_should_notify(vdev, vq)) { > return; > } > > diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h > index 4ce01a1..5884228 100644 > --- a/include/hw/virtio/virtio.h > +++ b/include/hw/virtio/virtio.h > @@ -162,6 +162,7 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int *in_bytes, > unsigned int *out_bytes, > unsigned max_in_bytes, unsigned max_out_bytes); > > +bool virtio_should_notify(VirtIODevice *vdev, VirtQueue *vq); > void virtio_notify(VirtIODevice *vdev, VirtQueue *vq); > > void virtio_save(VirtIODevice *vdev, QEMUFile *f); > -- > 1.8.3.1 > > > Reviewed-by: Fam Zheng