From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-trivial@nongnu.org, Thomas Huth <thuth@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] s390: remove misleading comment
Date: Tue, 16 Feb 2016 10:47:23 +0100 [thread overview]
Message-ID: <20160216104723.5b728fc8.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1455604235-3313-1-git-send-email-mjt@msgid.tls.msk.ru>
On Tue, 16 Feb 2016 09:30:35 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:
> The comment talks about a non-ELF object while the
> example gives ELF object.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index c9cf7cc..2213405 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
> /* Adjust ELF start address to final location */
> ipl->bios_start_addr += fwbase;
> } else {
> - /* Try to load non-ELF file (e.g. s390-ccw.img) */
> + /* Try to load non-ELF file */
> bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START,
> 4096);
> ipl->bios_start_addr = ZIPL_IMAGE_START;
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
prev parent reply other threads:[~2016-02-16 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:30 [Qemu-devel] [PATCH] s390: remove misleading comment Michael Tokarev
2016-02-16 8:52 ` Thomas Huth
2016-02-16 9:47 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160216104723.5b728fc8.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=mjt@tls.msk.ru \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).