* [Qemu-devel] [PATCH] s390: remove misleading comment
@ 2016-02-16 6:30 Michael Tokarev
2016-02-16 8:52 ` Thomas Huth
2016-02-16 9:47 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Michael Tokarev @ 2016-02-16 6:30 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Thomas Huth, Michael Tokarev
The comment talks about a non-ELF object while the
example gives ELF object.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/s390x/ipl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
index c9cf7cc..2213405 100644
--- a/hw/s390x/ipl.c
+++ b/hw/s390x/ipl.c
@@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
/* Adjust ELF start address to final location */
ipl->bios_start_addr += fwbase;
} else {
- /* Try to load non-ELF file (e.g. s390-ccw.img) */
+ /* Try to load non-ELF file */
bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START,
4096);
ipl->bios_start_addr = ZIPL_IMAGE_START;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390: remove misleading comment
2016-02-16 6:30 [Qemu-devel] [PATCH] s390: remove misleading comment Michael Tokarev
@ 2016-02-16 8:52 ` Thomas Huth
2016-02-16 9:47 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2016-02-16 8:52 UTC (permalink / raw)
To: Michael Tokarev, qemu-devel
Cc: qemu-trivial, Christian Borntraeger, Cornelia Huck, Pierre Morel,
Richard Henderson
On 16.02.2016 07:30, Michael Tokarev wrote:
> The comment talks about a non-ELF object while the
> example gives ELF object.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index c9cf7cc..2213405 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
> /* Adjust ELF start address to final location */
> ipl->bios_start_addr += fwbase;
> } else {
> - /* Try to load non-ELF file (e.g. s390-ccw.img) */
> + /* Try to load non-ELF file */
> bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START,
> 4096);
> ipl->bios_start_addr = ZIPL_IMAGE_START;
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390: remove misleading comment
2016-02-16 6:30 [Qemu-devel] [PATCH] s390: remove misleading comment Michael Tokarev
2016-02-16 8:52 ` Thomas Huth
@ 2016-02-16 9:47 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2016-02-16 9:47 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, Thomas Huth, qemu-devel
On Tue, 16 Feb 2016 09:30:35 +0300
Michael Tokarev <mjt@tls.msk.ru> wrote:
> The comment talks about a non-ELF object while the
> example gives ELF object.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> hw/s390x/ipl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> index c9cf7cc..2213405 100644
> --- a/hw/s390x/ipl.c
> +++ b/hw/s390x/ipl.c
> @@ -106,7 +106,7 @@ static void s390_ipl_realize(DeviceState *dev, Error **errp)
> /* Adjust ELF start address to final location */
> ipl->bios_start_addr += fwbase;
> } else {
> - /* Try to load non-ELF file (e.g. s390-ccw.img) */
> + /* Try to load non-ELF file */
> bios_size = load_image_targphys(bios_filename, ZIPL_IMAGE_START,
> 4096);
> ipl->bios_start_addr = ZIPL_IMAGE_START;
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-16 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-16 6:30 [Qemu-devel] [PATCH] s390: remove misleading comment Michael Tokarev
2016-02-16 8:52 ` Thomas Huth
2016-02-16 9:47 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).