From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48187) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVcO0-0005Nc-M1 for qemu-devel@nongnu.org; Tue, 16 Feb 2016 04:57:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVcNx-0006iX-D7 for qemu-devel@nongnu.org; Tue, 16 Feb 2016 04:57:36 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:48066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVcNx-0006iB-31 for qemu-devel@nongnu.org; Tue, 16 Feb 2016 04:57:33 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 16 Feb 2016 09:57:29 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 48FA81B0805F for ; Tue, 16 Feb 2016 09:57:42 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1G9vQFo50921690 for ; Tue, 16 Feb 2016 09:57:26 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1G9vPhl012665 for ; Tue, 16 Feb 2016 02:57:25 -0700 Date: Tue, 16 Feb 2016 10:57:19 +0100 From: Greg Kurz Message-ID: <20160216105719.7d53d99a@bahia.huguette.org> In-Reply-To: <56BB0F5C.4070804@redhat.com> References: <20160205103927.21017.26364.stgit@bahia.huguette.org> <56BB0F5C.4070804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/6] virtio/vhost cross-endian cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Cornelia Huck , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Wed, 10 Feb 2016 11:22:20 +0100 Laurent Vivier wrote: > On 05/02/2016 11:39, Greg Kurz wrote: > > This series brings some improvements to the cross-endian support in the > > virtio and vhost code: > > - use qemu_set_vnet_be() and qemu_set_vnet_le() directly from virtio-net, > > so that backend cross-endian capabilities benefit to both emulated and > > vhost accelerated devices > > - optimize virtio_access_is_big_endian() for little-endian targets > > - various cleanups > > > > This v4 is a respin of the v3, taking into account the following fix: > > > > commit cf0a628f6e81bfc9b7a944fa0b80c3594836df56 > > Author: Laurent Vivier > > Date: Wed Jan 13 20:26:25 2016 +0100 > > > > net: set endianness on all backend devices > > > > It impacts patches 1 and 2, that had already been reviewed. > > > > Laurent, Cornelia, > > > > Could you please ack/nack the changes ? > > > > The series is based on Michael Tsirkin's tree: > > > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git pci > > > > Thanks. > > > > -- > > Greg > > > > --- > > > > Greg Kurz (6): > > virtio-net: use the backend cross-endian capabilities > > vhost-net: revert support of cross-endian vnet headers > > virtio: move cross-endian helper to vhost > > vhost: move virtio 1.0 check to cross-endian helper > > vhost: simplify vhost_needs_vring_endian() > > virtio: optimize virtio_access_is_big_endian() for little-endian targets > > > > > > hw/net/vhost_net.c | 41 +++------------------- > > hw/net/virtio-net.c | 68 ++++++++++++++++++++++++++++++++++++- > > hw/virtio/vhost.c | 27 +++++++++++++-- > > include/hw/virtio/virtio-access.h | 28 ++------------- > > include/hw/virtio/virtio-net.h | 1 + > > 5 files changed, 98 insertions(+), 67 deletions(-) > > > > Reviewed-by: Laurent Vivier > Michael, Laurent has posted this R-b according to your request on irc. Most patches in this series have also been reviewed by Cornelia. Is there something else that prevents inclusion ? Thanks. -- Greg