From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVeXd-0002fs-Mb for qemu-devel@nongnu.org; Tue, 16 Feb 2016 07:15:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVeXZ-0005hF-QU for qemu-devel@nongnu.org; Tue, 16 Feb 2016 07:15:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVeXZ-0005h4-In for qemu-devel@nongnu.org; Tue, 16 Feb 2016 07:15:37 -0500 Date: Tue, 16 Feb 2016 12:15:32 +0000 From: "Daniel P. Berrange" Message-ID: <20160216121532.GC11370@redhat.com> References: <87povy5mim.fsf@blackfin.pond.sub.org> <20160215103440.GC7978@pxdev.xzpeter.org> <87y4amhuz2.fsf@blackfin.pond.sub.org> <87d1rxhid5.fsf@blackfin.pond.sub.org> <20160215201815.yheakyujt4axevse@hawk.localdomain> <87bn7hufrk.fsf@blackfin.pond.sub.org> <20160216101510.GB11370@redhat.com> <1455624345.4617.86.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1455624345.4617.86.camel@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [libvirt] [RFC PATCH 0/2] ARM: add QMP command to query GIC version Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrea Bolognani Cc: Wei Huang , Peter Maydell , Andrew Jones , Libvirt , Markus Armbruster , Peter Xu , QEMU Developers , Paolo Bonzini On Tue, Feb 16, 2016 at 01:05:45PM +0100, Andrea Bolognani wrote: > On Tue, 2016-02-16 at 10:15 +0000, Daniel P. Berrange wrote: > > > Back to GIV.=C2=A0=C2=A0Recognized values of gic-version are fixed = at compile > > > time: 2, 3, host.=C2=A0=C2=A0Once again, QOM does things in code ra= ther than data: > > > the set of values is defined in the setter function > > > virt_set_gic_version(). > > >=C2=A0 > > > Some values are accepted only together with other configuration: 3 > > > requires accel=3Dkvm (for now), host requires -cpu host.=C2=A0=C2=A0= Static > > > introspection can't show such constraints. > > >=C2=A0 > > > Would the proposed query-gic-capability show them?=C2=A0=C2=A0How? > >=C2=A0 > > Also bear in mind that libvirt probes capabilities using '-m none' so > > you're not going to have any 'virt' machine type instantiated when > > probing is done. >=20 > The idea is to add this information to domain capabilities, which > already have virtualization type, architecture and machine type as > inputs. Regardless of the way it is exposed in libvirt API, when libvirt probes for capabilities it will *always* use '-m none'. Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|