From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aVzYa-0002js-T0 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:42:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aVzYZ-0003Qw-Ky for qemu-devel@nongnu.org; Wed, 17 Feb 2016 05:42:04 -0500 Date: Wed, 17 Feb 2016 10:41:49 +0000 From: "Daniel P. Berrange" Message-ID: <20160217104149.GH30300@redhat.com> References: <1455546821-6671-1-git-send-email-berrange@redhat.com> <20160215155327.GH5244@noname.str.redhat.com> <20160217101058.GG30300@redhat.com> <20160217103752.GD29494@noname.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160217103752.GD29494@noname.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v6 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org On Wed, Feb 17, 2016 at 11:37:52AM +0100, Kevin Wolf wrote: > Am 17.02.2016 um 11:10 hat Daniel P. Berrange geschrieben: > > On Mon, Feb 15, 2016 at 04:53:27PM +0100, Kevin Wolf wrote: > > > Am 15.02.2016 um 15:33 hat Daniel P. Berrange geschrieben: > > > > This series of patches expands the syntax of the qemu-img, > > > > qemu-nbd and qemu-io commands to make them more flexible. > > > > > > > > v0: https://lists.gnu.org/archive/html/qemu-devel/2015-10/msg04365.html > > > > v1: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04014.html > > > > v2: https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg04354.html > > > > v3: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg03381.html > > > > v4: https://lists.gnu.org/archive/html/qemu-devel/2016-01/msg04984.html > > > > v5: https://lists.gnu.org/archive/html/qemu-block/2016-02/msg00022.html > > > > > > > > First all three gain a --object parameter, which allows > > > > instantiation of user creatable object types. The immediate > > > > use case is to allow for creation of the 'secret' object > > > > type to pass passwords for curl, iscsi and rbd drivers. > > > > For qemu-nbd this will also be needed to create TLS > > > > certificates for encryption support. > > > > > > > > Then all three gain a '--image-opts' parameter which causes > > > > the positional filenames to be interepreted as option strings > > > > rather tha nplain filenames. This avoids the need to use the > > > > JSON syntax, or to add custom CLI args for each block backend > > > > option that exists. The immediate use case is to allow the > > > > user to specify the ID of the 'secret' object they just created. > > > > > > > > Finally, there are a few small cleanup patches > > > > > > Thanks, applied to the block branch. > > > > The NBD patches just merged, so I've rebased this series and sent you > > a v7 to resolve the conflicts > > *sigh* Okay, I'll drop this series and re-review sometime later. NB it was a pretty clear rebase with no functional changes. Mostly just resolving conflicts in the "struct option" list entries used for getopt_long Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|