From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0Vv-0004yU-0j for qemu-devel@nongnu.org; Wed, 17 Feb 2016 06:43:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW0Vr-0008SC-P1 for qemu-devel@nongnu.org; Wed, 17 Feb 2016 06:43:22 -0500 Received: from e06smtp06.uk.ibm.com ([195.75.94.102]:60412) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0Vr-0008Rn-DE for qemu-devel@nongnu.org; Wed, 17 Feb 2016 06:43:19 -0500 Received: from localhost by e06smtp06.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Feb 2016 11:43:17 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 8DD2F2190023 for ; Wed, 17 Feb 2016 11:43:00 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1HBhF9X4850142 for ; Wed, 17 Feb 2016 11:43:15 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1HBhFIA030050 for ; Wed, 17 Feb 2016 04:43:15 -0700 Date: Wed, 17 Feb 2016 12:43:13 +0100 From: Cornelia Huck Message-ID: <20160217124313.15241a4a.cornelia.huck@de.ibm.com> In-Reply-To: <1455656347-29033-3-git-send-email-ehabkost@redhat.com> References: <1455656347-29033-1-git-send-email-ehabkost@redhat.com> <1455656347-29033-3-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/4] s390x/css: Allocate channel_subsys statically List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Christian Borntraeger , Alexander Graf , Richard Henderson , qemu-devel@nongnu.org, Marcel Apfelbaum On Tue, 16 Feb 2016 18:59:05 -0200 Eduardo Habkost wrote: > There's no need to use g_malloc0() to allocate the channel_subsys > struct, just use a static variable. The original intention was to model that dynamically somehow, but I don't see that happening anytime soon, so we can just keep it simple. > > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: Alexander Graf > Signed-off-by: Eduardo Habkost > --- > hw/s390x/css.c | 177 ++++++++++++++++++++++++++++----------------------------- > 1 file changed, 88 insertions(+), 89 deletions(-) Seems fine. Should this go through the s390x tree, or will it go through another tree together with the other patches? In any case, have a Reviewed-by: Cornelia Huck