From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>,
Richard Henderson <rth@twiddle.net>,
qemu-devel@nongnu.org, Marcel Apfelbaum <marcel.a@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] s390x/css: Use static initialization for channel_subsys fields
Date: Wed, 17 Feb 2016 12:44:01 +0100 [thread overview]
Message-ID: <20160217124401.791cdf31.cornelia.huck@de.ibm.com> (raw)
In-Reply-To: <1455656347-29033-4-git-send-email-ehabkost@redhat.com>
On Tue, 16 Feb 2016 18:59:06 -0200
Eduardo Habkost <ehabkost@redhat.com> wrote:
> machine_init() will be gone, but we don't need it if we just
> initialize the channel_subsys fields statically.
>
> Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> Cc: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> hw/s390x/css.c | 22 +++++++++-------------
> 1 file changed, 9 insertions(+), 13 deletions(-)
Same comment as for the other patch.
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
next prev parent reply other threads:[~2016-02-17 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 20:59 [Qemu-devel] [PATCH 0/4] machine: Eliminate machine_init()/MODULE_INIT_MACHINE Eduardo Habkost
2016-02-16 20:59 ` [Qemu-devel] [PATCH 1/4] machine: Use type_init() to register machine classes Eduardo Habkost
2016-02-17 15:32 ` Marcel Apfelbaum
2016-02-17 15:57 ` Michael S. Tsirkin
2016-02-18 2:35 ` David Gibson
2016-02-16 20:59 ` [Qemu-devel] [PATCH 2/4] s390x/css: Allocate channel_subsys statically Eduardo Habkost
2016-02-17 11:43 ` Cornelia Huck
2016-02-17 21:03 ` Eduardo Habkost
2016-02-23 11:12 ` Cornelia Huck
2016-02-16 20:59 ` [Qemu-devel] [PATCH 3/4] s390x/css: Use static initialization for channel_subsys fields Eduardo Habkost
2016-02-17 11:44 ` Cornelia Huck [this message]
2016-02-16 20:59 ` [Qemu-devel] [PATCH 4/4] module: Rename machine_init() to opts_init() Eduardo Habkost
2016-02-17 15:36 ` Marcel Apfelbaum
2016-02-17 15:58 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160217124401.791cdf31.cornelia.huck@de.ibm.com \
--to=cornelia.huck@de.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=ehabkost@redhat.com \
--cc=marcel.a@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).