From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45781) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0Wf-0005zt-Ra for qemu-devel@nongnu.org; Wed, 17 Feb 2016 06:44:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW0Wc-00006h-Gm for qemu-devel@nongnu.org; Wed, 17 Feb 2016 06:44:09 -0500 Received: from e06smtp14.uk.ibm.com ([195.75.94.110]:53791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW0Wc-00006b-5S for qemu-devel@nongnu.org; Wed, 17 Feb 2016 06:44:06 -0500 Received: from localhost by e06smtp14.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 17 Feb 2016 11:44:04 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 4A2A71B0804B for ; Wed, 17 Feb 2016 11:44:20 +0000 (GMT) Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u1HBi3b957606258 for ; Wed, 17 Feb 2016 11:44:03 GMT Received: from d06av02.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u1HBi33e018067 for ; Wed, 17 Feb 2016 04:44:03 -0700 Date: Wed, 17 Feb 2016 12:44:01 +0100 From: Cornelia Huck Message-ID: <20160217124401.791cdf31.cornelia.huck@de.ibm.com> In-Reply-To: <1455656347-29033-4-git-send-email-ehabkost@redhat.com> References: <1455656347-29033-1-git-send-email-ehabkost@redhat.com> <1455656347-29033-4-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] s390x/css: Use static initialization for channel_subsys fields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Christian Borntraeger , Alexander Graf , Richard Henderson , qemu-devel@nongnu.org, Marcel Apfelbaum On Tue, 16 Feb 2016 18:59:06 -0200 Eduardo Habkost wrote: > machine_init() will be gone, but we don't need it if we just > initialize the channel_subsys fields statically. > > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Richard Henderson > Cc: Alexander Graf > Signed-off-by: Eduardo Habkost > --- > hw/s390x/css.c | 22 +++++++++------------- > 1 file changed, 9 insertions(+), 13 deletions(-) Same comment as for the other patch. Reviewed-by: Cornelia Huck