From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW1qU-0002PZ-BU for qemu-devel@nongnu.org; Wed, 17 Feb 2016 08:08:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aW1qP-0003en-7U for qemu-devel@nongnu.org; Wed, 17 Feb 2016 08:08:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54338) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aW1qO-0003eh-RX for qemu-devel@nongnu.org; Wed, 17 Feb 2016 08:08:37 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 9775FA452B for ; Wed, 17 Feb 2016 13:08:36 +0000 (UTC) Date: Wed, 17 Feb 2016 21:08:22 +0800 From: Peter Xu Message-ID: <20160217130822.GJ7978@pxdev.xzpeter.org> References: <1455609061-16279-1-git-send-email-peterx@redhat.com> <1455609061-16279-9-git-send-email-peterx@redhat.com> <20160216123936.rce57s2gb76ql2p7@hawk.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160216123936.rce57s2gb76ql2p7@hawk.localdomain> Subject: Re: [Qemu-devel] [PATCH v7 08/11] DumpState: adding total_size and written_size fields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andrew Jones Cc: famz@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, pbonzini@redhat.com, lersek@redhat.com On Tue, Feb 16, 2016 at 01:39:36PM +0100, Andrew Jones wrote: > On Tue, Feb 16, 2016 at 03:50:58PM +0800, Peter Xu wrote: > > Here, total_size is the size in bytes to be dumped (raw data, which > > means before compression), while written_size are bytes handled (raw > > size too). > > > > Signed-off-by: Peter Xu > > Reviewed-by: Fam Zheng > > --- > > dump.c | 32 ++++++++++++++++++++++++++++++++ > > include/sysemu/dump.h | 9 +++++++++ > > 2 files changed, 41 insertions(+) > > > > diff --git a/dump.c b/dump.c > > index 9210a72..ca2400d 100644 > > --- a/dump.c > > +++ b/dump.c > > @@ -331,6 +331,8 @@ static void write_data(DumpState *s, void *buf, int length, Error **errp) > > ret = fd_write_vmcore(buf, length, s); > > if (ret < 0) { > > error_setg(errp, "dump: failed to save memory"); > > + } else { > > + s->written_size += length; > > } > > } > > > > @@ -1324,6 +1326,7 @@ static void write_dump_pages(DumpState *s, Error **errp) > > goto out; > > } > > } > > + s->written_size += TARGET_PAGE_SIZE; > > Don't use TARGET_PAGE_SIZE, use s->dump_info.page_size, see 8161befd > Will fix. Thanks! Peter