From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56646) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWGxs-0006vv-MS for qemu-devel@nongnu.org; Thu, 18 Feb 2016 00:17:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWGxr-0002uY-E2 for qemu-devel@nongnu.org; Thu, 18 Feb 2016 00:17:20 -0500 Date: Thu, 18 Feb 2016 10:47:02 +0530 From: Amit Shah Message-ID: <20160218051702.GA4440@grmbl.mre> References: <1455259174-3384-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455259174-3384-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , qemu-devel@nongnu.org, qemu-block@nongnu.org, Juan Quintela Can someone from the block team please give this a review? Thanks, On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote: > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The problem is that qcow2_invalidate_cache() closes the image and > memset()s BDRVQcowState in the middle. > > This operation should not be performed in coroutine context. > > Changes from v1: > - fixed spelling. Eric, thank you for spell checking > > Signed-off-by: Denis V. Lunev > CC: Paolo Bonzini > CC: Juan Quintela > CC: Amit Shah > Amit