qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Leonid Bloch <leonid.bloch@ravellosystems.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
	Jason Wang <jasowang@redhat.com>,
	Leonid Bloch <leonid@daynix.com>,
	qemu-devel@nongnu.org,
	Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>
Subject: Re: [Qemu-devel] [PATCH 01/13] msix: make msix_clr_pending() visible for clients
Date: Thu, 18 Feb 2016 12:23:25 +0200	[thread overview]
Message-ID: <20160218122313-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1455790054-1952-2-git-send-email-leonid.bloch@ravellosystems.com>

On Thu, Feb 18, 2016 at 12:07:22PM +0200, Leonid Bloch wrote:
> From: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> 
> This function will be used by e1000e device code.
> 
> Signed-off-by: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> Signed-off-by: Leonid Bloch <leonid.bloch@ravellosystems.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci/msix.c         | 2 +-
>  include/hw/pci/msix.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/pci/msix.c b/hw/pci/msix.c
> index eb4ef11..cce89d9 100644
> --- a/hw/pci/msix.c
> +++ b/hw/pci/msix.c
> @@ -72,7 +72,7 @@ void msix_set_pending(PCIDevice *dev, unsigned int vector)
>      *msix_pending_byte(dev, vector) |= msix_pending_mask(vector);
>  }
>  
> -static void msix_clr_pending(PCIDevice *dev, int vector)
> +void msix_clr_pending(PCIDevice *dev, int vector)
>  {
>      *msix_pending_byte(dev, vector) &= ~msix_pending_mask(vector);
>  }
> diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h
> index 72e5f93..048a29d 100644
> --- a/include/hw/pci/msix.h
> +++ b/include/hw/pci/msix.h
> @@ -29,6 +29,7 @@ int msix_present(PCIDevice *dev);
>  
>  bool msix_is_masked(PCIDevice *dev, unsigned vector);
>  void msix_set_pending(PCIDevice *dev, unsigned vector);
> +void msix_clr_pending(PCIDevice *dev, int vector);
>  
>  int msix_vector_use(PCIDevice *dev, unsigned vector);
>  void msix_vector_unuse(PCIDevice *dev, unsigned vector);
> -- 
> 2.5.0

  reply	other threads:[~2016-02-18 10:23 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 10:07 [Qemu-devel] [PATCH 00/13] Introduce Intel 82574 GbE Controller Emulation (e1000e) Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 01/13] msix: make msix_clr_pending() visible for clients Leonid Bloch
2016-02-18 10:23   ` Michael S. Tsirkin [this message]
2016-02-18 10:07 ` [Qemu-devel] [PATCH 02/13] pci: Introduce define for PM capability version 1.1 Leonid Bloch
2016-02-18 10:27   ` Michael S. Tsirkin
2016-02-22 16:31     ` Leonid Bloch
2016-02-22 19:08       ` Michael S. Tsirkin
2016-02-18 10:07 ` [Qemu-devel] [PATCH 03/13] pcie: Add support for PCIe CAP v1 Leonid Bloch
2016-02-18 10:35   ` Michael S. Tsirkin
2016-02-22 16:36     ` Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 04/13] pcie: Introduce function for DSN capability creation Leonid Bloch
2016-02-18 10:41   ` Michael S. Tsirkin
2016-02-22 16:42     ` Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 05/13] vmxnet3: Use generic function for DSN capability definition Leonid Bloch
2016-02-18 10:46   ` Michael S. Tsirkin
2016-02-22 16:44     ` Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 06/13] net: Introduce Toeplitz hash calculator Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 07/13] net: Add macros for MAC address tracing Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 08/13] vmxnet3: Use common MAC address tracing macros Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 09/13] net_pkt: Name vmxnet3 packet abstractions more generic Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 10/13] rtl8139: Move more TCP definitions to common header Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 11/13] net_pkt: Extend packet abstraction as required by e1000e functionality Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 12/13] e1000_regs: Add definitions for Intel 82574-specific bits Leonid Bloch
2016-02-18 10:07 ` [Qemu-devel] [PATCH 13/13] net: Introduce e1000e device emulation Leonid Bloch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218122313-mutt-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=dmitry@daynix.com \
    --cc=jasowang@redhat.com \
    --cc=leonid.bloch@ravellosystems.com \
    --cc=leonid@daynix.com \
    --cc=qemu-devel@nongnu.org \
    --cc=shmulik.ladkani@ravellosystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).