From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54623)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aWLkD-0007lC-RG
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 05:23:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aWLk9-0005ag-RN
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 05:23:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:37229)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1aWLk9-0005aa-Lk
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 05:23:29 -0500
Date: Thu, 18 Feb 2016 12:23:25 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160218122313-mutt-send-email-mst@redhat.com>
References: <1455790054-1952-1-git-send-email-leonid.bloch@ravellosystems.com>
	<1455790054-1952-2-git-send-email-leonid.bloch@ravellosystems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1455790054-1952-2-git-send-email-leonid.bloch@ravellosystems.com>
Subject: Re: [Qemu-devel] [PATCH 01/13] msix: make msix_clr_pending()
	visible for clients
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leonid Bloch <leonid.bloch@ravellosystems.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>, Jason Wang <jasowang@redhat.com>, Leonid Bloch <leonid@daynix.com>, qemu-devel@nongnu.org, Shmulik Ladkani <shmulik.ladkani@ravellosystems.com>

On Thu, Feb 18, 2016 at 12:07:22PM +0200, Leonid Bloch wrote:
> From: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> 
> This function will be used by e1000e device code.
> 
> Signed-off-by: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
> Signed-off-by: Leonid Bloch <leonid.bloch@ravellosystems.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  hw/pci/msix.c         | 2 +-
>  include/hw/pci/msix.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hw/pci/msix.c b/hw/pci/msix.c
> index eb4ef11..cce89d9 100644
> --- a/hw/pci/msix.c
> +++ b/hw/pci/msix.c
> @@ -72,7 +72,7 @@ void msix_set_pending(PCIDevice *dev, unsigned int vector)
>      *msix_pending_byte(dev, vector) |= msix_pending_mask(vector);
>  }
>  
> -static void msix_clr_pending(PCIDevice *dev, int vector)
> +void msix_clr_pending(PCIDevice *dev, int vector)
>  {
>      *msix_pending_byte(dev, vector) &= ~msix_pending_mask(vector);
>  }
> diff --git a/include/hw/pci/msix.h b/include/hw/pci/msix.h
> index 72e5f93..048a29d 100644
> --- a/include/hw/pci/msix.h
> +++ b/include/hw/pci/msix.h
> @@ -29,6 +29,7 @@ int msix_present(PCIDevice *dev);
>  
>  bool msix_is_masked(PCIDevice *dev, unsigned vector);
>  void msix_set_pending(PCIDevice *dev, unsigned vector);
> +void msix_clr_pending(PCIDevice *dev, int vector);
>  
>  int msix_vector_use(PCIDevice *dev, unsigned vector);
>  void msix_vector_unuse(PCIDevice *dev, unsigned vector);
> -- 
> 2.5.0