From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWQDt-0003Xy-C6 for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:10:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWQDo-00006y-1D for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:10:29 -0500 Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:42800) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWQDn-00006d-NC for qemu-devel@nongnu.org; Thu, 18 Feb 2016 10:10:23 -0500 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 18 Feb 2016 15:10:22 -0000 Date: Thu, 18 Feb 2016 16:10:15 +0100 From: Greg Kurz Message-ID: <20160218161015.7dd8a833@bahia.huguette.org> In-Reply-To: <87povuawo2.fsf@blackfin.pond.sub.org> References: <20160218144045.7349.67293.stgit@bahia.huguette.org> <87povuawo2.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] spapr: initialize local Error pointer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson On Thu, 18 Feb 2016 16:02:53 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > This fixes a crash in the target QEMU during migration. > > > > Fixes: c5f54f3e31bf693f70a98d4d73ea5dbe05689857 > > Suggest to word that as "Broken in commit c5f54f3." > This is more explicit indeed. I'll do that for future patches. Thanks ! > > Signed-off-by: Greg Kurz > > --- > > hw/ppc/spapr.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > > index e214a34257b3..c119f5582429 100644 > > --- a/hw/ppc/spapr.c > > +++ b/hw/ppc/spapr.c > > @@ -1528,7 +1528,7 @@ static int htab_load(QEMUFile *f, void *opaque, int version_id) > > section_hdr = qemu_get_be32(f); > > > > if (section_hdr) { > > - Error *local_err; > > + Error *local_err = NULL; > > > > /* First section gives the htab size */ > > spapr_reallocate_hpt(spapr, section_hdr, &local_err); > > Easy mistake to make (I've made it myself). I wish I had the time to > figure out how to make Coccinelle catch it. > > Reviewed-by: Markus Armbruster >