qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 02/13] vfio: make the 4 bytes aligned for capability size
Date: Thu, 18 Feb 2016 13:05:57 -0700	[thread overview]
Message-ID: <20160218200557.29220.98603.stgit@gimli.home> (raw)
In-Reply-To: <20160218200419.29220.39836.stgit@gimli.home>

From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>

this function search the capability from the end, the last
size should 0x100 - pos, not 0xff - pos.

Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/pci.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index 49f3d2d..e671506 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1505,7 +1505,8 @@ static void vfio_unmap_bars(VFIOPCIDevice *vdev)
  */
 static uint8_t vfio_std_cap_max_size(PCIDevice *pdev, uint8_t pos)
 {
-    uint8_t tmp, next = 0xff;
+    uint8_t tmp;
+    uint16_t next = PCI_CONFIG_SPACE_SIZE;
 
     for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp;
          tmp = pdev->config[tmp + 1]) {

  parent reply	other threads:[~2016-02-18 20:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-18 20:05 [Qemu-devel] [PULL 00/13] VFIO updates 2016-02-18 Alex Williamson
2016-02-18 20:05 ` [Qemu-devel] [PULL 01/13] pcie: modify the capability size assert Alex Williamson
2016-02-18 20:05 ` Alex Williamson [this message]
2016-02-18 20:06 ` [Qemu-devel] [PULL 03/13] aer: impove pcie_aer_init to support vfio device Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 04/13] pcie_aer: expose pcie_aer_msg() interface Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 05/13] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 06/13] hw/vfio/platform: amd-xgbe device Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 07/13] device_tree: introduce load_device_tree_from_sysfs Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 08/13] device_tree: introduce qemu_fdt_node_path Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 09/13] device_tree: qemu_fdt_getprop converted to use the error API Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 10/13] device_tree: qemu_fdt_getprop_cell " Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 11/13] hw/arm/sysbus-fdt: helpers for clock node generation Alex Williamson
2016-02-18 20:06 ` [Qemu-devel] [PULL 12/13] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation Alex Williamson
2016-02-18 20:07 ` [Qemu-devel] [PULL 13/13] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check Alex Williamson
2016-02-19 10:50 ` [Qemu-devel] [PULL 00/13] VFIO updates 2016-02-18 Peter Maydell
2016-02-19 12:20   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160218200557.29220.98603.stgit@gimli.home \
    --to=alex.williamson@redhat.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).