From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38416)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aWad7-00016h-1U
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 21:17:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aWad3-0001vX-O5
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 21:17:12 -0500
Received: from mx1.redhat.com ([209.132.183.28]:47888)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1aWad3-0001vE-J7
	for qemu-devel@nongnu.org; Thu, 18 Feb 2016 21:17:09 -0500
Date: Fri, 19 Feb 2016 10:17:03 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160219021703.GB23506@ad.usersys.redhat.com>
References: <1455689899-31227-1-git-send-email-famz@redhat.com>
	<56C5AE40.6080809@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56C5AE40.6080809@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: Fix missing right
	parantheses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Janosch Frank <frankja@linux.vnet.ibm.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Thu, 02/18 12:42, Janosch Frank wrote:
> On 02/17/2016 07:18 AM, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> >  scripts/kvm/kvm_stat | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> > index 3cf1181..517fbec 100755
> > --- a/scripts/kvm/kvm_stat
> > +++ b/scripts/kvm/kvm_stat
> > @@ -800,7 +800,7 @@ def check_access(options):
> >          if options.tracepoints:
> >              sys.exit(1)
> > 
> > -        sys.stderr.write("Falling back to debugfs statistics!\n"
> > +        sys.stderr.write("Falling back to debugfs statistics!\n")
> >          options.debugfs = True
> >          sleep(5)
> > 
> Thanks for fixing that.
> If you also want to fix the missing .format(PATH_DEBUGFS_TRACING) in the
> write a few lines above, go ahead.
> 
> I should have been more careful when reading the pull mail from Paolo.
> The affected lines are not my code and definitely not my v2 which
> included the "exit if -t is passed explicitly" that Paolo added to my
> commit.
> 

Yep, I can do it. Will send v2.

Fam