From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWelk-0005hI-Os for qemu-devel@nongnu.org; Fri, 19 Feb 2016 01:42:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWelh-0002H2-Qf for qemu-devel@nongnu.org; Fri, 19 Feb 2016 01:42:24 -0500 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:37081) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWelh-0002GO-Hy for qemu-devel@nongnu.org; Fri, 19 Feb 2016 01:42:21 -0500 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 19 Feb 2016 06:42:18 -0000 Date: Fri, 19 Feb 2016 07:42:10 +0100 From: Greg Kurz Message-ID: <20160219074210.768a5ed5@bahia.huguette.org> In-Reply-To: <56C622E6.20909@redhat.com> References: <20160218113211.9760.85475.stgit@bahia.huguette.org> <56C622E6.20909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 0/2] Fix migration of old pseries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: Juan Quintela , qemu-devel@nongnu.org, "Dr. David Alan Gilbert" , qemu-ppc@nongnu.org, Amit Shah , David Gibson On Thu, 18 Feb 2016 21:00:38 +0100 Laurent Vivier wrote: > On 18/02/2016 12:32, Greg Kurz wrote: > > QEMU 2.4 broke the migration of old pseries machine with the addition > > of configuration sections, which are sent unconditionally. > > > > We assume that QEMU 2.3 is more deployed than any newer release (based on > > the versions currently shipped by most distros). This v3 series hence > > reverses the logic from v2: it now fully fixes migration of old pseries > > from/to QEMU 2.3 and provides a manual workaround for the QEMU 2.4/2.4.1/2.5 > > case. > > > > With this series, I could migrate the same pseries-2.3 instance in a full > > 2.3->2.6->2.5->2.6->2.4->2.6->2.3 cycle. > > > > --- > > > > Greg Kurz (2): > > spapr: skip configuration section during migration of older machines > > migration: allow machine to enforce configuration section migration > > > > > > hw/core/machine.c | 21 +++++++++++++++++++++ > > hw/ppc/spapr.c | 1 + > > include/hw/boards.h | 1 + > > migration/savevm.c | 10 ++++++++-- > > qemu-options.hx | 3 ++- > > 5 files changed, 33 insertions(+), 3 deletions(-) > > For the series > Tested-by: Laurent Vivier > > Results of tests: > > pseries-2.3 > > qemu-2.3.0 -> qemu-master: OK > qemu-2.3.1 -> qemu-master: OK > qemu-2.4.0 -> qemu-master: OK with qom-set > qemu-2.4.1 -> qemu-master: OK with qom-set > qemu-2.5.0 -> qemu-master: OK with qom-set > qemu-master -> qemu-2.3.0: OK > qemu-master -> qemu-2.3.1: OK > qemu-master -> qemu-2.4.0: OK with qom-set > qemu-master -> qemu-2.4.1: OK with qom-set > qemu-master -> qemu-2.5.0: OK with qom-set > qemu-master -> qemu-master: OK > > pseries-2.4, pseries-2.5 and pseries-2.6 works well with the patch > applied too. > > master is "b527c9b qcow2: Write full header on image creation" + this series > > Laurent > Thanks for the reviewing and testing ! Cheers. -- Greg