From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50007) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWfiC-0004qa-LF for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:42:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWfi9-0006Wj-DD for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:42:48 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWfi9-0006Wa-7n for qemu-devel@nongnu.org; Fri, 19 Feb 2016 02:42:45 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D897FC0006F6 for ; Fri, 19 Feb 2016 07:42:44 +0000 (UTC) Date: Fri, 19 Feb 2016 09:42:41 +0200 From: "Michael S. Tsirkin" Message-ID: <20160219094145-mutt-send-email-mst@redhat.com> References: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1455470231-5223-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/8] virtio: allow migration with dataplane List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Sun, Feb 14, 2016 at 06:17:03PM +0100, Paolo Bonzini wrote: > Currently, dataplane threads are shut down during migration because > vring.c is not able to track dirty memory. However, all the relevant > parts of QEMU have been made thread-safe now, so we can drop vring.c > completely. With these patches, virtio-dataplane is now simply "virtio > with ioeventfd in a different AioContext". virtio bits look OK to me. Removing flags like started and disabled can happen later. > > Paolo Bonzini (8): > block-migration: acquire AioContext as necessary > vring: make vring_enable_notification return void > virtio: add AioContext-specific function for host notifiers > virtio: export vring_notify as virtio_should_notify > virtio-blk: fix "disabled data plane" mode > virtio-blk: do not use vring in dataplane > virtio-scsi: do not use vring in dataplane > vring: remove > > hw/block/dataplane/virtio-blk.c | 130 +----- > hw/block/dataplane/virtio-blk.h | 1 + > hw/block/virtio-blk.c | 51 +-- > hw/scsi/virtio-scsi-dataplane.c | 196 ++------- > hw/scsi/virtio-scsi.c | 52 +-- > hw/virtio/Makefile.objs | 1 - > hw/virtio/dataplane/Makefile.objs | 1 - > hw/virtio/dataplane/vring.c | 549 -------------------------- > hw/virtio/virtio.c | 20 +- > include/hw/virtio/dataplane/vring-accessors.h | 75 ---- > include/hw/virtio/dataplane/vring.h | 51 --- > include/hw/virtio/virtio-blk.h | 4 +- > include/hw/virtio/virtio-scsi.h | 21 +- > include/hw/virtio/virtio.h | 3 + > migration/block.c | 61 ++- > trace-events | 3 - > 16 files changed, 134 insertions(+), 1085 deletions(-) > delete mode 100644 hw/virtio/dataplane/Makefile.objs > delete mode 100644 hw/virtio/dataplane/vring.c > delete mode 100644 include/hw/virtio/dataplane/vring-accessors.h > delete mode 100644 include/hw/virtio/dataplane/vring.h > > -- > 1.8.3.1