From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aWoBV-0001wR-Ex for qemu-devel@nongnu.org; Fri, 19 Feb 2016 11:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aWoBR-0007kQ-KX for qemu-devel@nongnu.org; Fri, 19 Feb 2016 11:45:37 -0500 Date: Fri, 19 Feb 2016 09:45:32 -0700 From: Alex Williamson Message-ID: <20160219094532.47e2f131@t450s.home> In-Reply-To: <1455895091-7589-2-git-send-email-richard.weiyang@gmail.com> References: <1455895091-7589-1-git-send-email-richard.weiyang@gmail.com> <1455895091-7589-2-git-send-email-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Yang Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org On Fri, 19 Feb 2016 15:18:10 +0000 Wei Yang wrote: > Even PCI_CAP_FLAGS has the same value as PCI_MSIX_FLAGS, the later one is > the more proper on retrieving MSIX entries. > > This patch uses PCI_MSIX_FLAGS to retrieve the MSIX entries. > > Signed-off-by: Wei Yang > --- > hw/vfio/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index e66c47f..321423b 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -1210,7 +1210,7 @@ static int vfio_msix_early_setup(VFIOPCIDevice *vdev) > } > > if (pread(fd, &ctrl, sizeof(ctrl), > - vdev->config_offset + pos + PCI_CAP_FLAGS) != sizeof(ctrl)) { > + vdev->config_offset + pos + PCI_MSIX_FLAGS) != sizeof(ctrl)) { > return -errno; > } > This is certainly trivial, I'll grab it for the respin of yesterday's pull request. Thanks, Alex