qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Chen Fan <chen.fan.fnst@cn.fujitsu.com>,
	Marcel Apfelbaum <marcel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PULL 01/14] pcie: modify the capability size assert
Date: Fri, 19 Feb 2016 10:39:37 -0700	[thread overview]
Message-ID: <20160219173937.16497.8830.stgit@gimli.home> (raw)
In-Reply-To: <20160219173708.16497.23357.stgit@gimli.home>

From: Chen Fan <chen.fan.fnst@cn.fujitsu.com>

Device's Offset and size can reach PCIE_CONFIG_SPACE_SIZE,
fix the corresponding assert.

Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/pci/pcie.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 435a6cf..4aca0c5 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -608,7 +608,7 @@ void pcie_add_capability(PCIDevice *dev,
 
     assert(offset >= PCI_CONFIG_SPACE_SIZE);
     assert(offset < offset + size);
-    assert(offset + size < PCIE_CONFIG_SPACE_SIZE);
+    assert(offset + size <= PCIE_CONFIG_SPACE_SIZE);
     assert(size >= 8);
     assert(pci_is_express(dev));
 

  reply	other threads:[~2016-02-19 17:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 17:39 [Qemu-devel] [PULL 00/14] VFIO updates 2016-02-19 Alex Williamson
2016-02-19 17:39 ` Alex Williamson [this message]
2016-02-19 17:39 ` [Qemu-devel] [PULL 02/14] vfio: make the 4 bytes aligned for capability size Alex Williamson
2016-02-19 17:39 ` [Qemu-devel] [PULL 03/14] aer: impove pcie_aer_init to support vfio device Alex Williamson
2016-02-19 17:39 ` [Qemu-devel] [PULL 04/14] pcie_aer: expose pcie_aer_msg() interface Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 05/14] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 06/14] hw/vfio/platform: amd-xgbe device Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 07/14] device_tree: introduce load_device_tree_from_sysfs Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 08/14] device_tree: introduce qemu_fdt_node_path Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 09/14] device_tree: qemu_fdt_getprop converted to use the error API Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 10/14] device_tree: qemu_fdt_getprop_cell " Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 11/14] hw/arm/sysbus-fdt: helpers for clock node generation Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 12/14] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 13/14] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 14/14] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries Alex Williamson
2016-02-19 17:47 ` [Qemu-devel] [PULL 00/14] VFIO updates 2016-02-19 Alex Williamson
2016-02-19 18:34 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219173937.16497.8830.stgit@gimli.home \
    --to=alex.williamson@redhat.com \
    --cc=chen.fan.fnst@cn.fujitsu.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).