qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: qemu-devel@nongnu.org
Cc: Wei Yang <richard.weiyang@gmail.com>
Subject: [Qemu-devel] [PULL 05/14] vfio/pci: replace 1 with PCI_CAP_LIST_NEXT to make code self-explain
Date: Fri, 19 Feb 2016 10:40:00 -0700	[thread overview]
Message-ID: <20160219174000.16497.35187.stgit@gimli.home> (raw)
In-Reply-To: <20160219173708.16497.23357.stgit@gimli.home>

From: Wei Yang <richard.weiyang@gmail.com>

Use the macro PCI_CAP_LIST_NEXT instead of 1, so that the code would be
more self-explain.

This patch makes this change and also fixs one typo in comment.

Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/vfio/pci.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index e671506..dc5fa9f 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -1509,7 +1509,7 @@ static uint8_t vfio_std_cap_max_size(PCIDevice *pdev, uint8_t pos)
     uint16_t next = PCI_CONFIG_SPACE_SIZE;
 
     for (tmp = pdev->config[PCI_CAPABILITY_LIST]; tmp;
-         tmp = pdev->config[tmp + 1]) {
+         tmp = pdev->config[tmp + PCI_CAP_LIST_NEXT]) {
         if (tmp > pos && tmp < next) {
             next = tmp;
         }
@@ -1698,7 +1698,7 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t pos)
     int ret;
 
     cap_id = pdev->config[pos];
-    next = pdev->config[pos + 1];
+    next = pdev->config[pos + PCI_CAP_LIST_NEXT];
 
     /*
      * If it becomes important to configure capabilities to their actual
@@ -1712,7 +1712,7 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t pos)
      * pci_add_capability always inserts the new capability at the head
      * of the chain.  Therefore to end up with a chain that matches the
      * physical device, we insert from the end by making this recursive.
-     * This is also why we pre-caclulate size above as cached config space
+     * This is also why we pre-calculate size above as cached config space
      * will be changed as we unwind the stack.
      */
     if (next) {
@@ -1728,7 +1728,7 @@ static int vfio_add_std_cap(VFIOPCIDevice *vdev, uint8_t pos)
     }
 
     /* Use emulated next pointer to allow dropping caps */
-    pci_set_byte(vdev->emulated_config_bits + pos + 1, 0xff);
+    pci_set_byte(vdev->emulated_config_bits + pos + PCI_CAP_LIST_NEXT, 0xff);
 
     switch (cap_id) {
     case PCI_CAP_ID_MSI:

  parent reply	other threads:[~2016-02-19 17:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-19 17:39 [Qemu-devel] [PULL 00/14] VFIO updates 2016-02-19 Alex Williamson
2016-02-19 17:39 ` [Qemu-devel] [PULL 01/14] pcie: modify the capability size assert Alex Williamson
2016-02-19 17:39 ` [Qemu-devel] [PULL 02/14] vfio: make the 4 bytes aligned for capability size Alex Williamson
2016-02-19 17:39 ` [Qemu-devel] [PULL 03/14] aer: impove pcie_aer_init to support vfio device Alex Williamson
2016-02-19 17:39 ` [Qemu-devel] [PULL 04/14] pcie_aer: expose pcie_aer_msg() interface Alex Williamson
2016-02-19 17:40 ` Alex Williamson [this message]
2016-02-19 17:40 ` [Qemu-devel] [PULL 06/14] hw/vfio/platform: amd-xgbe device Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 07/14] device_tree: introduce load_device_tree_from_sysfs Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 08/14] device_tree: introduce qemu_fdt_node_path Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 09/14] device_tree: qemu_fdt_getprop converted to use the error API Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 10/14] device_tree: qemu_fdt_getprop_cell " Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 11/14] hw/arm/sysbus-fdt: helpers for clock node generation Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 12/14] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 13/14] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check Alex Williamson
2016-02-19 17:40 ` [Qemu-devel] [PULL 14/14] vfio/pci: use PCI_MSIX_FLAGS on retrieving the MSIX entries Alex Williamson
2016-02-19 17:47 ` [Qemu-devel] [PULL 00/14] VFIO updates 2016-02-19 Alex Williamson
2016-02-19 18:34 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160219174000.16497.35187.stgit@gimli.home \
    --to=alex.williamson@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.weiyang@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).