From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXXy5-0004Yr-O7 for qemu-devel@nongnu.org; Sun, 21 Feb 2016 12:38:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXXy4-0007D6-Jv for qemu-devel@nongnu.org; Sun, 21 Feb 2016 12:38:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXXy4-0007Cy-CA for qemu-devel@nongnu.org; Sun, 21 Feb 2016 12:38:48 -0500 Date: Sun, 21 Feb 2016 19:38:44 +0200 From: "Michael S. Tsirkin" Message-ID: <20160221173844.GA25820@redhat.com> References: <1446475788-11190-1-git-send-email-ghammer@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1446475788-11190-1-git-send-email-ghammer@redhat.com> Subject: Re: [Qemu-devel] [PATCH] qga: implement the guest-set-vcpus for windows List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gal Hammer Cc: qemu-devel@nongnu.org, Michael Roth On Mon, Nov 02, 2015 at 04:49:48PM +0200, Gal Hammer wrote: > Signed-off-by: Gal Hammer Seems to make sense. Acked-by: Michael S. Tsirkin mdroth, any feedback on this one? > --- > qga/commands-win32.c | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 64 insertions(+), 2 deletions(-) > > diff --git a/qga/commands-win32.c b/qga/commands-win32.c > index d9de23b..a8eb4a0 100644 > --- a/qga/commands-win32.c > +++ b/qga/commands-win32.c > @@ -1181,7 +1181,69 @@ void qmp_guest_set_time(bool has_time, int64_t time_ns, Error **errp) > > GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) > { > - error_setg(errp, QERR_UNSUPPORTED); > + PSYSTEM_LOGICAL_PROCESSOR_INFORMATION pslpi, ptr; > + DWORD length; > + GuestLogicalProcessorList *head, **link; > + Error *local_err = NULL; > + int64_t current; > + > + ptr = pslpi = NULL; > + length = 0; > + current = 0; > + head = NULL; > + link = &head; > + > + if ((GetLogicalProcessorInformation(pslpi, &length) == FALSE) && > + (GetLastError() == ERROR_INSUFFICIENT_BUFFER) && > + (length > sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION))) { > + ptr = pslpi = g_malloc0(length); > + if (GetLogicalProcessorInformation(pslpi, &length) == FALSE) { > + error_setg(&local_err, "Failed to get processor information: %d", > + (int)GetLastError()); > + } > + } else { > + error_setg(&local_err, > + "Failed to get processor information buffer length: %d", > + (int)GetLastError()); > + } > + > + while ((local_err == NULL) && (length > 0)) { > + if (pslpi->Relationship == RelationProcessorCore) { > + ULONG_PTR cpu_bits = pslpi->ProcessorMask; > + > + while (cpu_bits > 0) { > + if (!!(cpu_bits & 1)) { > + GuestLogicalProcessor *vcpu; > + GuestLogicalProcessorList *entry; > + > + vcpu = g_malloc0(sizeof *vcpu); > + vcpu->logical_id = current++; > + vcpu->online = true; > + vcpu->has_can_offline = false; > + > + entry = g_malloc0(sizeof *entry); > + entry->value = vcpu; > + > + *link = entry; > + link = &entry->next; > + } > + cpu_bits >>= 1; > + } > + } > + length -= sizeof(SYSTEM_LOGICAL_PROCESSOR_INFORMATION); > + pslpi++; /* next entry */ > + } > + > + g_free(ptr); > + > + if (local_err == NULL) { > + /* there's no guest with zero VCPUs */ > + g_assert(head != NULL); > + return head; > + } > + > + qapi_free_GuestLogicalProcessorList(head); > + error_propagate(errp, local_err); > return NULL; > } > > @@ -1295,7 +1357,7 @@ GList *ga_command_blacklist_init(GList *blacklist) > { > const char *list_unsupported[] = { > "guest-suspend-hybrid", > - "guest-get-vcpus", "guest-set-vcpus", > + "guest-set-vcpus", > "guest-get-memory-blocks", "guest-set-memory-blocks", > "guest-get-memory-block-size", > "guest-fsfreeze-freeze-list", > -- > 2.1.0 >