From: Amit Shah <amit.shah@redhat.com>
To: Wei Yang <richard.weiyang@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: reorder code to make it symmetric
Date: Mon, 22 Feb 2016 09:22:30 +0530 [thread overview]
Message-ID: <20160222035230.GA10967@grmbl.mre> (raw)
In-Reply-To: <1454626230-16334-1-git-send-email-richard.weiyang@gmail.com>
On (Thu) 04 Feb 2016 [22:50:30], Wei Yang wrote:
> In qemu_savevm_state_complete_precopy(), it iterates on each device to add
> a json object and transfer related status to destination, while the order
> of the last two steps could be refined.
>
> Current order:
>
> json_start_object()
> save_section_header()
> vmstate_save()
> json_end_object()
> save_section_footer()
>
> After the change:
>
> json_start_object()
> save_section_header()
> vmstate_save()
> save_section_footer()
> json_end_object()
>
> This patch reorder the code to to make it symmetric. No functional change.
>
> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Thanks,
Amit
prev parent reply other threads:[~2016-02-22 3:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-04 22:50 [Qemu-devel] [PATCH] migration: reorder code to make it symmetric Wei Yang
2016-02-11 0:56 ` Wei Yang
2016-02-20 0:34 ` Wei Yang
2016-02-22 3:52 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222035230.GA10967@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.weiyang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).