From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXmWd-00057N-HE for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXmWc-0004yD-Lw for qemu-devel@nongnu.org; Mon, 22 Feb 2016 04:11:27 -0500 Date: Mon, 22 Feb 2016 10:11:20 +0100 From: Kevin Wolf Message-ID: <20160222091120.GB5387@noname.str.redhat.com> References: <1455897130-27625-1-git-send-email-kwolf@redhat.com> <56C73EE9.1040909@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56C73EE9.1040909@redhat.com> Subject: Re: [Qemu-devel] [PATCH] block: Fix -incoming with snapshot=on List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: lvivier@redhat.com, qemu-devel@nongnu.org, qemu-block@nongnu.org Am 19.02.2016 um 17:12 hat Paolo Bonzini geschrieben: > > > On 19/02/2016 16:52, Kevin Wolf wrote: > > The BDRV_O_INACTIVE flag should only be set for images explicitly opened > > by the user. snapshot=on needs to create a new qcow2 image and write > > some metadata to it. This is not a problem because it can't come from > > the source, so there's no reason to mark it as BDRV_O_INACTIVE, even > > though it is opened while waiting for the migration to complete. > > > > This fixes an assertion failure when -incoming and snapshot=on are > > combined. > > > > Signed-off-by: Kevin Wolf > > Does this also fix "migrate -b"? No, that still fails for me. I think 'migrate -b' needs to clear BDRV_O_INACTIVE before it starts using the image on the destination. I wonder how it ever worked without this, it should have thrown all of the metadata caches away instead of writing them to the image. Kevin