From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXpmK-0004bN-SM for qemu-devel@nongnu.org; Mon, 22 Feb 2016 07:39:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXpmG-0004Eg-Sb for qemu-devel@nongnu.org; Mon, 22 Feb 2016 07:39:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXpmG-0004EO-N2 for qemu-devel@nongnu.org; Mon, 22 Feb 2016 07:39:48 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 835CF627C6 for ; Mon, 22 Feb 2016 12:39:47 +0000 (UTC) Date: Mon, 22 Feb 2016 18:09:40 +0530 From: Amit Shah Message-ID: <20160222123940.GD10967@grmbl.mre> References: <1483e0d74dcfd183ff46dd63cc57e1fe8b775bf8.1454680535.git.amit.shah@redhat.com> <56BC86C6.6060103@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56BC86C6.6060103@redhat.com> Subject: Re: [Qemu-devel] [PULL 8/9] static checker: e1000-82540em got aliased to e1000 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Jason Wang (jasowang@redhat.com)" , Juan Quintela , qemu list , "Dr. David Alan Gilbert" On (Thu) 11 Feb 2016 [14:04:06], Paolo Bonzini wrote: > > > On 05/02/2016 14:56, Amit Shah wrote: > > Commit 8304402033e8dbe8e379017d51ed1dd8344f1dce changed the name of the > > e1000-82540em device to e1000. This was flagged: > > > > Section "e1000-82540em" does not exist in dest > > > > Add the mapping to the changed section names dictionary so the checker > > can proceed. > > > > Signed-off-by: Amit Shah > > Acked-by: Jason Wang > > Message-Id: <7ccfe834c897142dceaa4da87c13b7059fa12aa8.1450416947.git.amit.shah@redhat.com> > > Signed-off-by: Amit Shah > > --- > > scripts/vmstate-static-checker.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/scripts/vmstate-static-checker.py b/scripts/vmstate-static-checker.py > > index b6c0bbe..b5ecaf6 100755 > > --- a/scripts/vmstate-static-checker.py > > +++ b/scripts/vmstate-static-checker.py > > @@ -99,6 +99,7 @@ def get_changed_sec_name(sec): > > # Section names can change -- see commit 292b1634 for an example. > > changes = { > > "ICH9 LPC": "ICH9-LPC", > > + "e1000-82540em": "e1000", > > } > > > > for item in changes: > > > > This means that 2.5 cannot migrate 2.4 virtual machines, right? Is that > something we want to rectify in 2.6 by making e1000-82540em an alias of > e1000 (instead of the other way round)? You're right; I misread it. With that commit (8304402033): 2.4 with e1000-82540em will not migrate to 2.5 with e1000-82540em. This is despite they're aliased (so the cmdline is backward compatible), but the migration device name actually changed. Of course, 2.5->2.4 will also not work. Since 2.4 emits 'e1000-82540em' as the device name in the migration stream, and 2.5 emits just 'e1000', we have two different names for the same device in two versions. To fix this, we'll need a hack on the dest side to allow e1000 and e1000-82540em in the migration stream for the device, and this can be done for 2.6 and 2.5.stable. Jason, can you attempt this? Amit