From: Stefan Hajnoczi <stefanha@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: daniel@iogearbox.net, prem@barefootnetworks.com,
jasowang@redhat.com, qemu-devel@nongnu.org,
parag.bhide@barefootnetworks.com, idosch@mellanox.com,
sfeldma@gmail.com, eladr@mellanox.com, pbonzini@redhat.com,
alexei.starovoitov@gmail.com
Subject: Re: [Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property
Date: Mon, 22 Feb 2016 17:51:50 +0000 [thread overview]
Message-ID: <20160222175150.GD10927@stefanha-x1.localdomain> (raw)
In-Reply-To: <1455876403-8575-4-git-send-email-jiri@resnulli.us>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Fri, Feb 19, 2016 at 11:06:43AM +0100, Jiri Pirko wrote:
> @@ -1297,7 +1310,18 @@ static int pci_rocker_init(PCIDevice *dev)
> /* allocate worlds */
>
> r->worlds[ROCKER_WORLD_TYPE_OF_DPA] = of_dpa_world_alloc(r);
> - r->world_dflt = r->worlds[ROCKER_WORLD_TYPE_OF_DPA];
> +
> + if (!r->world_name) {
> + r->world_name = g_strdup(world_name(r->worlds[ROCKER_WORLD_TYPE_OF_DPA]));
> + }
> +
> + r->world_dflt = rocker_world_type_by_name(r, r->world_name);
> + if (!r->world_dflt) {
> + fprintf(stderr,
> + "rocker: requested world \"%s\" does not exist\n",
> + r->world_name);
> + return -EINVAL;
> + }
world_name is leaked here. Please use goto to run the appropriate
cleanup code instead of returning directly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-02-22 17:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 10:06 [Qemu-devel] [patch qemu 0/3] rocker: prepare for easy addition of other worlds Jiri Pirko
2016-02-19 10:06 ` [Qemu-devel] [patch qemu 1/3] rocker: forbid to change world type Jiri Pirko
2016-02-19 10:06 ` [Qemu-devel] [patch qemu 2/3] rocker: add name field into WorldOps ale let world specify its name Jiri Pirko
2016-02-19 10:06 ` [Qemu-devel] [patch qemu 3/3] rocker: allow user to specify rocker world by property Jiri Pirko
2016-02-22 17:51 ` Stefan Hajnoczi [this message]
2016-02-22 18:06 ` Jiri Pirko
2016-02-25 11:31 ` Stefan Hajnoczi
2016-02-25 11:48 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160222175150.GD10927@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=parag.bhide@barefootnetworks.com \
--cc=pbonzini@redhat.com \
--cc=prem@barefootnetworks.com \
--cc=qemu-devel@nongnu.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).