From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXvr2-000416-9h for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:09:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXvqx-0005oM-JB for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:09:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51773) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXvqx-0005oI-DS for qemu-devel@nongnu.org; Mon, 22 Feb 2016 14:09:03 -0500 Date: Mon, 22 Feb 2016 21:08:58 +0200 From: "Michael S. Tsirkin" Message-ID: <20160222210753-mutt-send-email-mst@redhat.com> References: <1455790054-1952-1-git-send-email-leonid.bloch@ravellosystems.com> <1455790054-1952-3-git-send-email-leonid.bloch@ravellosystems.com> <20160218122356-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH 02/13] pci: Introduce define for PM capability version 1.1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leonid Bloch Cc: Dmitry Fleytman , Jason Wang , Leonid Bloch , qemu-devel@nongnu.org, Shmulik Ladkani On Mon, Feb 22, 2016 at 06:31:04PM +0200, Leonid Bloch wrote: > Dear Michael, > > Thanks very much for your review! Please see comments inline. > > Best regards, > Leonid. > > On Thu, Feb 18, 2016 at 12:27 PM, Michael S. Tsirkin wrote: > > On Thu, Feb 18, 2016 at 12:07:23PM +0200, Leonid Bloch wrote: > >> From: Dmitry Fleytman > >> > >> Signed-off-by: Dmitry Fleytman > >> Signed-off-by: Leonid Bloch > > > > Sorry no - these are standard headers. > > You could add it in include/hw/pci/pci_regs.h > > OK, added to include/hw/pci/pci_regs.h in v2. You don't need to post such comments. Just include changelog in the next revision. > > but I'm not sure it's worth it since there's > > a single user ... > > Maybe just use a number and add a comment where it's used. > > > >> --- > >> include/standard-headers/linux/pci_regs.h | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/include/standard-headers/linux/pci_regs.h b/include/standard-headers/linux/pci_regs.h > >> index 1becea8..cfb5db2 100644 > >> --- a/include/standard-headers/linux/pci_regs.h > >> +++ b/include/standard-headers/linux/pci_regs.h > >> @@ -226,6 +226,7 @@ > >> > >> #define PCI_PM_PMC 2 /* PM Capabilities Register */ > >> #define PCI_PM_CAP_VER_MASK 0x0007 /* Version */ > >> +#define PCI_PM_CAP_VER_1_1 0x0002 /* PCI PM spec ver. 1.1 */ > >> #define PCI_PM_CAP_PME_CLOCK 0x0008 /* PME clock required */ > >> #define PCI_PM_CAP_RESERVED 0x0010 /* Reserved field */ > >> #define PCI_PM_CAP_DSI 0x0020 /* Device specific initialization */ > >> -- > >> 2.5.0