From: Amit Shah <amit.shah@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: jdenemar@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org,
quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/1] Postcopy+spice: Pass spice migration data earlier
Date: Tue, 23 Feb 2016 13:56:54 +0530 [thread overview]
Message-ID: <20160223082654.GG10967@grmbl.mre> (raw)
In-Reply-To: <1456161452-25318-1-git-send-email-dgilbert@redhat.com>
On (Mon) 22 Feb 2016 [17:17:32], Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> Spice hooks the migration status changes to figure out when to
> transmit information to the new spice server; but the migration
> status in postcopy doesn't quite fit - the destination starts
> running before the end of the source migration.
>
> It's not a case of hanging off the migration status change to
> postcopy-active either, since that happens before we stop the
> guest CPU.
>
> Fix it by sending a notify just after sending the device state,
> and adding a flag that can be tested by the notify receiver.
>
> Symptom:
> spice handover doesn't work with the error:
> red_worker.c:11540:display_channel_wait_for_migrate_data: timeout
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Amit
prev parent reply other threads:[~2016-02-23 8:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 17:17 [Qemu-devel] [PATCH 1/1] Postcopy+spice: Pass spice migration data earlier Dr. David Alan Gilbert (git)
2016-02-23 8:26 ` Amit Shah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160223082654.GG10967@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=jdenemar@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).