From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY8JG-0001y9-PY for qemu-devel@nongnu.org; Tue, 23 Feb 2016 03:27:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY8JD-0002dV-H6 for qemu-devel@nongnu.org; Tue, 23 Feb 2016 03:27:06 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY8JD-0002dJ-BT for qemu-devel@nongnu.org; Tue, 23 Feb 2016 03:27:03 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 0E589C0E56AC for ; Tue, 23 Feb 2016 08:27:03 +0000 (UTC) Date: Tue, 23 Feb 2016 13:56:54 +0530 From: Amit Shah Message-ID: <20160223082654.GG10967@grmbl.mre> References: <1456161452-25318-1-git-send-email-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456161452-25318-1-git-send-email-dgilbert@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/1] Postcopy+spice: Pass spice migration data earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert (git)" Cc: jdenemar@redhat.com, kraxel@redhat.com, qemu-devel@nongnu.org, quintela@redhat.com On (Mon) 22 Feb 2016 [17:17:32], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Spice hooks the migration status changes to figure out when to > transmit information to the new spice server; but the migration > status in postcopy doesn't quite fit - the destination starts > running before the end of the source migration. > > It's not a case of hanging off the migration status change to > postcopy-active either, since that happens before we stop the > guest CPU. > > Fix it by sending a notify just after sending the device state, > and adding a flag that can be tested by the notify receiver. > > Symptom: > spice handover doesn't work with the error: > red_worker.c:11540:display_channel_wait_for_migrate_data: timeout > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit