From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY9Qt-00031S-Qo for qemu-devel@nongnu.org; Tue, 23 Feb 2016 04:39:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY9Qr-0005qj-3C for qemu-devel@nongnu.org; Tue, 23 Feb 2016 04:39:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY9Qq-0005qf-SU for qemu-devel@nongnu.org; Tue, 23 Feb 2016 04:39:01 -0500 Date: Tue, 23 Feb 2016 15:08:50 +0530 From: Amit Shah Message-ID: <20160223093850.GH10967@grmbl.mre> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 0/5] migration pull List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , liang.z.li@intel.com Cc: qemu list , "Dr. David Alan Gilbert" , Juan Quintela On (Tue) 23 Feb 2016 [09:09:46], Peter Maydell wrote: > On 23 February 2016 at 07:30, Amit Shah wrote: > > The following changes since commit 8eb779e4223a18db9838a49ece1bc72cfd= fb7761: > > > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into= staging (2016-02-22 16:55:41 +0000) > > > > are available in the git repository at: > > > > https://git.kernel.org/pub/scm/virt/qemu/amit/migration.git tags/mi= gration-for-2.6-3 > > > > for you to fetch changes up to 612f0af57aa1e8d4e09d7f1a1c442e1d943cbf= 0c: > > > > cutils: add avx2 instruction optimization (2016-02-23 12:53:03 +053= 0) > > > > ---------------------------------------------------------------- > > Migration: > > - enable avx2 instructions when available > > - fix a qcow2 assert > > - minor code rearrangement >=20 > Hi. I'm afraid this doesn't compile for x86-64 Linux: Compiles for me, but adding Liang Li so he can respond. >=20 > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98can_use_buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:242:29: error: > =E2=80=98__m256i=E2=80=99 undeclared (first use in this function) > * sizeof(AVX2_VECTYPE)) =3D=3D 0 > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:242:29: note: each > undeclared identifier is reported only once for each function it > appears in > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:248:5: error: > unknown type name =E2=80=98__m256i=E2=80=99 > const AVX2_VECTYPE *p =3D buf; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:249:5: error: > unknown type name =E2=80=98__m256i=E2=80=99 > const AVX2_VECTYPE zero =3D (AVX2_VECTYPE){0}; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:249:27: error: > =E2=80=98__m256i=E2=80=99 undeclared (first use in this function) > const AVX2_VECTYPE zero =3D (AVX2_VECTYPE){0}; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:249:35: error: > expected =E2=80=98,=E2=80=99 or =E2=80=98;=E2=80=99 before =E2=80=98{=E2= =80=99 token > const AVX2_VECTYPE zero =3D (AVX2_VECTYPE){0}; > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:259:9: error: > implicit declaration of function =E2=80=98_mm256_movemask_epi8=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > if (!AVX2_ALL_EQ(p[i], zero)) { > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:259:9: error: > nested extern declaration of =E2=80=98_mm256_movemask_epi8=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:259:9: error: > implicit declaration of function =E2=80=98_mm256_cmpeq_epi8=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:259:9: error: > nested extern declaration of =E2=80=98_mm256_cmpeq_epi8=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:267:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp0=E2=80=99 > AVX2_VECTYPE tmp0 =3D AVX2_VEC_OR(p[i + 0], p[i + 1]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:268:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp1=E2=80=99 > AVX2_VECTYPE tmp1 =3D AVX2_VEC_OR(p[i + 2], p[i + 3]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:269:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp2=E2=80=99 > AVX2_VECTYPE tmp2 =3D AVX2_VEC_OR(p[i + 4], p[i + 5]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:270:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp3=E2=80=99 > AVX2_VECTYPE tmp3 =3D AVX2_VEC_OR(p[i + 6], p[i + 7]); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:271:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp01=E2=80=99 > AVX2_VECTYPE tmp01 =3D AVX2_VEC_OR(tmp0, tmp1); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:272:17: error: > expected =E2=80=98;=E2=80=99 before =E2=80=98tmp23=E2=80=99 > AVX2_VECTYPE tmp23 =3D AVX2_VEC_OR(tmp2, tmp3); > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:273:9: error: > implicit declaration of function =E2=80=98_mm256_or_si256=E2=80=99 > [-Werror=3Dimplicit-function-declaration] > if (!AVX2_ALL_EQ(AVX2_VEC_OR(tmp01, tmp23), zero)) { > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:273:9: error: > nested extern declaration of =E2=80=98_mm256_or_si256=E2=80=99 > [-Werror=3Dnested-externs] > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:273:71: error: > =E2=80=98tmp01=E2=80=99 undeclared (first use in this function) > if (!AVX2_ALL_EQ(AVX2_VEC_OR(tmp01, tmp23), zero)) { > = ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:273:78: error: > =E2=80=98tmp23=E2=80=99 undeclared (first use in this function) > if (!AVX2_ALL_EQ(AVX2_VEC_OR(tmp01, tmp23), zero)) { > = ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98can_use_buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:244:1: error: > control reaches end of non-void function [-Werror=3Dreturn-type] > } > ^ > /home/petmay01/linaro/qemu-for-merges/util/cutils.c: In function > =E2=80=98buffer_find_nonzero_offset_avx2=E2=80=99: > /home/petmay01/linaro/qemu-for-merges/util/cutils.c:279:1: error: > control reaches end of non-void function [-Werror=3Dreturn-type] > } > ^ > cc1: all warnings being treated as errors >=20 > thanks > -- PMM Amit