From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYUiI-0008BN-Nn for qemu-devel@nongnu.org; Wed, 24 Feb 2016 03:22:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYUiF-0005zs-Gh for qemu-devel@nongnu.org; Wed, 24 Feb 2016 03:22:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYUiF-0005zk-Bt for qemu-devel@nongnu.org; Wed, 24 Feb 2016 03:22:23 -0500 Date: Wed, 24 Feb 2016 13:52:12 +0530 From: Amit Shah Message-ID: <20160224082212.GK10967@grmbl.mre> References: <1456242542-14042-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456242542-14042-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v3 0/2] move qcow2_invalidate_cache() out of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Paolo Bonzini , Fam Zheng , qemu-devel@nongnu.org, Juan Quintela On (Tue) 23 Feb 2016 [18:49:00], Denis V. Lunev wrote: > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The problem is that qcow2_invalidate_cache() closes the image and > memset()s BDRVQcowState in the middle. > > This operation should not be performed in coroutine context. > > Changes from v2: > - subject lines in patches Denis, did you see the comment by Fam to your patches? Amit