qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Jeff Cody <jcody@redhat.com>
Cc: pl@kamp.de, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] block/vpc: tests for auto-detecting VPC and Hyper-V VHD images
Date: Wed, 24 Feb 2016 11:23:29 +0100	[thread overview]
Message-ID: <20160224102329.GD4485@noname.redhat.com> (raw)
In-Reply-To: <4a7fc43138fff7dfbebfaf993835b315ea50d01b.1456274059.git.jcody@redhat.com>

Am 24.02.2016 um 01:47 hat Jeff Cody geschrieben:
> This tests auto-detection, and overrides, of VHD image sizes created
> by Virtual PC and Hyper-V.
> 
> This adds two sample images:
> 
> hyperv2012r2-dynamic.vhd.bz2 - dynamic VHD image created with Hyper-V
> virtualpc-dynamic.vhd.bz2    - dynamic VHD image created with Virtual PC
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>

> +echo
> +echo === Testing VPC Autodetect ===
> +echo
> +_use_sample_img virtualpc-dynamic.vhd.bz2
> +
> +_launch_qemu -drive file="${TEST_IMG}",id=disk,format=vpc
> +h1=$QEMU_HANDLE
> +
> +_send_qemu_cmd $h1 'qemu-io disk "map"' "sectors"
> +_send_qemu_cmd $h1 'quit' ""

I would avoid the big hammer of starting qemu processes when qemu-io can
test the same:

$QEMU_IO -c "open -o file=${TEST_IMG},id=disk,format=vpc" -c "map"

Kevin

  reply	other threads:[~2016-02-24 10:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24  0:47 [Qemu-devel] [PATCH 0/4] VHD/VPC format compatibility Jeff Cody
2016-02-24  0:47 ` [Qemu-devel] [PATCH 1/4] block/vpc: choose size calculation method based on creator_app field Jeff Cody
2016-02-24  0:47 ` [Qemu-devel] [PATCH 2/4] block/vpc: tests for auto-detecting VPC and Hyper-V VHD images Jeff Cody
2016-02-24 10:23   ` Kevin Wolf [this message]
2016-02-24 12:19     ` Jeff Cody
2016-02-24 15:40     ` Jeff Cody
2016-02-24 15:44       ` [Qemu-devel] [Qemu-block] " Max Reitz
2016-02-24 15:47         ` Jeff Cody
2016-02-24 15:49       ` Max Reitz
2016-02-24  0:47 ` [Qemu-devel] [PATCH 3/4] block/vpc: give option to force the current_size field in .bdrv_create Jeff Cody
2016-02-24 10:19   ` Kevin Wolf
2016-02-24 12:24     ` Jeff Cody
2016-02-24 12:44       ` Peter Lieven
2016-02-24 13:07         ` Kevin Wolf
2016-02-24 13:40           ` Jeff Cody
2016-02-24 19:28             ` Peter Lieven
2016-02-24 21:17               ` Jeff Cody
2016-02-24 19:29           ` Peter Lieven
2016-02-24  0:47 ` [Qemu-devel] [PATCH 4/4] block/vpc: add tests for image creation force_size parameter Jeff Cody

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160224102329.GD4485@noname.redhat.com \
    --to=kwolf@redhat.com \
    --cc=jcody@redhat.com \
    --cc=pl@kamp.de \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).