From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49811)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aYWbe-0005v5-Sm
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 05:23:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1aYWbe-0004qE-0V
	for qemu-devel@nongnu.org; Wed, 24 Feb 2016 05:23:42 -0500
Date: Wed, 24 Feb 2016 11:23:29 +0100
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160224102329.GD4485@noname.redhat.com>
References: <cover.1456274059.git.jcody@redhat.com>
	<4a7fc43138fff7dfbebfaf993835b315ea50d01b.1456274059.git.jcody@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4a7fc43138fff7dfbebfaf993835b315ea50d01b.1456274059.git.jcody@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] block/vpc: tests for auto-detecting
 VPC and Hyper-V VHD images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jeff Cody <jcody@redhat.com>
Cc: pl@kamp.de, qemu-devel@nongnu.org, qemu-block@nongnu.org

Am 24.02.2016 um 01:47 hat Jeff Cody geschrieben:
> This tests auto-detection, and overrides, of VHD image sizes created
> by Virtual PC and Hyper-V.
> 
> This adds two sample images:
> 
> hyperv2012r2-dynamic.vhd.bz2 - dynamic VHD image created with Hyper-V
> virtualpc-dynamic.vhd.bz2    - dynamic VHD image created with Virtual PC
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>

> +echo
> +echo === Testing VPC Autodetect ===
> +echo
> +_use_sample_img virtualpc-dynamic.vhd.bz2
> +
> +_launch_qemu -drive file="${TEST_IMG}",id=disk,format=vpc
> +h1=$QEMU_HANDLE
> +
> +_send_qemu_cmd $h1 'qemu-io disk "map"' "sectors"
> +_send_qemu_cmd $h1 'quit' ""

I would avoid the big hammer of starting qemu processes when qemu-io can
test the same:

$QEMU_IO -c "open -o file=${TEST_IMG},id=disk,format=vpc" -c "map"

Kevin