From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: marcandre.lureau@redhat.com, qemu-devel@nongnu.org
Cc: lersek@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/5] qga: use size_t for wcslen() return value
Date: Wed, 24 Feb 2016 09:34:25 -0600 [thread overview]
Message-ID: <20160224153425.29588.23196@loki> (raw)
In-Reply-To: <1455727675-20625-3-git-send-email-marcandre.lureau@redhat.com>
Quoting marcandre.lureau@redhat.com (2016-02-17 10:47:52)
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Reported-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
> ---
> qga/commands-win32.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 7baacc7..e5afc5d 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -1246,7 +1246,8 @@ get_net_error_message(gint error)
> HMODULE module = NULL;
> gchar *retval = NULL;
> wchar_t *msg = NULL;
> - int flags, nchars;
> + int flags;
> + size_t nchars;
>
> flags = FORMAT_MESSAGE_ALLOCATE_BUFFER |
> FORMAT_MESSAGE_IGNORE_INSERTS |
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-02-24 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 16:47 [Qemu-devel] [PATCH 0/5] qga: win32 guest-set-user-password improvements marcandre.lureau
2016-02-17 16:47 ` [Qemu-devel] [PATCH 1/5] qga: use more idiomatic qemu-style eol operators marcandre.lureau
2016-02-24 15:34 ` Michael Roth
2016-02-17 16:47 ` [Qemu-devel] [PATCH 2/5] qga: use size_t for wcslen() return value marcandre.lureau
2016-02-24 15:34 ` Michael Roth [this message]
2016-02-17 16:47 ` [Qemu-devel] [PATCH 3/5] qga: use wide-chars constants for wchar_t comparisons marcandre.lureau
2016-02-24 15:35 ` Michael Roth
2016-02-17 16:47 ` [Qemu-devel] [PATCH 4/5] qga: fix off-by-one length check marcandre.lureau
2016-02-24 15:37 ` Michael Roth
2016-02-17 16:47 ` [Qemu-devel] [PATCH 5/5] qga: check utf8-to-utf16 conversion marcandre.lureau
2016-02-24 15:38 ` Michael Roth
2016-02-17 17:02 ` [Qemu-devel] [PATCH 0/5] qga: win32 guest-set-user-password improvements Laszlo Ersek
2016-02-25 2:09 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160224153425.29588.23196@loki \
--to=mdroth@linux.vnet.ibm.com \
--cc=lersek@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).