From: Fam Zheng <famz@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Amit Shah <amit.shah@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of coroutine context
Date: Thu, 25 Feb 2016 09:21:43 +0800 [thread overview]
Message-ID: <20160225012143.GB14319@ad.usersys.redhat.com> (raw)
In-Reply-To: <1456304019-10507-1-git-send-email-den@openvz.org>
On Wed, 02/24 11:53, Denis V. Lunev wrote:
> There is a possibility to hit an assert in qcow2_get_specific_info that
> s->qcow_version is undefined. This happens when VM in starting from
> suspended state, i.e. it processes incoming migration, and in the same
> time 'info block' is called.
>
> The problem is that qcow2_invalidate_cache() closes the image and
> memset()s BDRVQcowState in the middle.
>
> This operation should not be performed in coroutine context.
>
> Changes from v3:
> - added qemu_bh_delete at the end of BH to free allocated structure.
> Thanks to Fam.
Looks good to me now. Thanks!
Reviewed-by: Fam Zheng <famz@redhat.com>
prev parent reply other threads:[~2016-02-25 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 8:53 [Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of coroutine context Denis V. Lunev
2016-02-24 8:53 ` [Qemu-devel] [PATCH 1/2] migration (ordinary): move bdrv_invalidate_cache_all of " Denis V. Lunev
2016-02-24 8:53 ` [Qemu-devel] [PATCH 2/2] migration (postcopy): " Denis V. Lunev
2016-02-25 1:21 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160225012143.GB14319@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=amit.shah@redhat.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).