From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkcp-0006l8-Up for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:21:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYkck-0005fR-Vf for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:21:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38067) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYkck-0005ee-Q1 for qemu-devel@nongnu.org; Wed, 24 Feb 2016 20:21:46 -0500 Date: Thu, 25 Feb 2016 09:21:43 +0800 From: Fam Zheng Message-ID: <20160225012143.GB14319@ad.usersys.redhat.com> References: <1456304019-10507-1-git-send-email-den@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1456304019-10507-1-git-send-email-den@openvz.org> Subject: Re: [Qemu-devel] [PATCH v4 0/2] move qcow2_invalidate_cache() out of coroutine context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Amit Shah , Paolo Bonzini , qemu-devel@nongnu.org, Juan Quintela On Wed, 02/24 11:53, Denis V. Lunev wrote: > There is a possibility to hit an assert in qcow2_get_specific_info that > s->qcow_version is undefined. This happens when VM in starting from > suspended state, i.e. it processes incoming migration, and in the same > time 'info block' is called. > > The problem is that qcow2_invalidate_cache() closes the image and > memset()s BDRVQcowState in the middle. > > This operation should not be performed in coroutine context. > > Changes from v3: > - added qemu_bh_delete at the end of BH to free allocated structure. > Thanks to Fam. Looks good to me now. Thanks! Reviewed-by: Fam Zheng