* [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate
@ 2016-02-25 10:03 Dr. David Alan Gilbert (git)
2016-02-25 10:55 ` Hailiang Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Dr. David Alan Gilbert (git) @ 2016-02-25 10:03 UTC (permalink / raw)
To: qemu-devel, amit.shah, quintela, jdenemar
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
I'd missed the sync count off in the postcopy case.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
migration/migration.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/migration.c b/migration/migration.c
index fc5e50b..34d3e5f 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
info->ram->normal_bytes = norm_mig_bytes_transferred();
info->ram->dirty_pages_rate = s->dirty_pages_rate;
info->ram->mbps = s->mbps;
+ info->ram->dirty_sync_count = s->dirty_sync_count;
if (blk_mig_active()) {
info->has_disk = true;
--
2.5.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate
2016-02-25 10:03 [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate Dr. David Alan Gilbert (git)
@ 2016-02-25 10:55 ` Hailiang Zhang
2016-02-25 10:59 ` Dr. David Alan Gilbert
0 siblings, 1 reply; 3+ messages in thread
From: Hailiang Zhang @ 2016-02-25 10:55 UTC (permalink / raw)
To: Dr. David Alan Gilbert (git), qemu-devel, amit.shah, quintela,
jdenemar
Cc: peter.huangpeng
On 2016/2/25 18:03, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> I'd missed the sync count off in the postcopy case.
>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> migration/migration.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index fc5e50b..34d3e5f 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
> info->ram->normal_bytes = norm_mig_bytes_transferred();
> info->ram->dirty_pages_rate = s->dirty_pages_rate;
> info->ram->mbps = s->mbps;
> + info->ram->dirty_sync_count = s->dirty_sync_count;
>
> if (blk_mig_active()) {
> info->has_disk = true;
>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
I noticed that, the stats of 'POSTCOPY_ACTIVE' is almost the copy of 'ACTIVE'
case. Maybe we can simplify it.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate
2016-02-25 10:55 ` Hailiang Zhang
@ 2016-02-25 10:59 ` Dr. David Alan Gilbert
0 siblings, 0 replies; 3+ messages in thread
From: Dr. David Alan Gilbert @ 2016-02-25 10:59 UTC (permalink / raw)
To: Hailiang Zhang; +Cc: amit.shah, jdenemar, qemu-devel, peter.huangpeng, quintela
* Hailiang Zhang (zhang.zhanghailiang@huawei.com) wrote:
> On 2016/2/25 18:03, Dr. David Alan Gilbert (git) wrote:
> >From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> >
> >I'd missed the sync count off in the postcopy case.
> >
> >Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> >---
> > migration/migration.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/migration/migration.c b/migration/migration.c
> >index fc5e50b..34d3e5f 100644
> >--- a/migration/migration.c
> >+++ b/migration/migration.c
> >@@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp)
> > info->ram->normal_bytes = norm_mig_bytes_transferred();
> > info->ram->dirty_pages_rate = s->dirty_pages_rate;
> > info->ram->mbps = s->mbps;
> >+ info->ram->dirty_sync_count = s->dirty_sync_count;
> >
> > if (blk_mig_active()) {
> > info->has_disk = true;
> >
>
> Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Thanks,
> I noticed that, the stats of 'POSTCOPY_ACTIVE' is almost the copy of 'ACTIVE'
> case. Maybe we can simplify it.
Yes, I keep intending to add more stats to POSTCOPY_ACTIVE, but haven't
done so yet.
Dave
>
>
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-25 10:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25 10:03 [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate Dr. David Alan Gilbert (git)
2016-02-25 10:55 ` Hailiang Zhang
2016-02-25 10:59 ` Dr. David Alan Gilbert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).