From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYte5-0003Kk-9U for qemu-devel@nongnu.org; Thu, 25 Feb 2016 05:59:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aYte1-0000Av-Vn for qemu-devel@nongnu.org; Thu, 25 Feb 2016 05:59:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aYte1-0000Al-QX for qemu-devel@nongnu.org; Thu, 25 Feb 2016 05:59:41 -0500 Date: Thu, 25 Feb 2016 10:59:37 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20160225105936.GB2163@work-vm> References: <1456394631-18010-1-git-send-email-dgilbert@redhat.com> <56CEDD8F.3070605@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56CEDD8F.3070605@huawei.com> Subject: Re: [Qemu-devel] [PATCH] Postcopy: Fix sync count in info migrate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Hailiang Zhang Cc: amit.shah@redhat.com, jdenemar@redhat.com, qemu-devel@nongnu.org, peter.huangpeng@huawei.com, quintela@redhat.com * Hailiang Zhang (zhang.zhanghailiang@huawei.com) wrote: > On 2016/2/25 18:03, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >I'd missed the sync count off in the postcopy case. > > > >Signed-off-by: Dr. David Alan Gilbert > >--- > > migration/migration.c | 1 + > > 1 file changed, 1 insertion(+) > > > >diff --git a/migration/migration.c b/migration/migration.c > >index fc5e50b..34d3e5f 100644 > >--- a/migration/migration.c > >+++ b/migration/migration.c > >@@ -626,6 +626,7 @@ MigrationInfo *qmp_query_migrate(Error **errp) > > info->ram->normal_bytes = norm_mig_bytes_transferred(); > > info->ram->dirty_pages_rate = s->dirty_pages_rate; > > info->ram->mbps = s->mbps; > >+ info->ram->dirty_sync_count = s->dirty_sync_count; > > > > if (blk_mig_active()) { > > info->has_disk = true; > > > > Reviewed-by: zhanghailiang Thanks, > I noticed that, the stats of 'POSTCOPY_ACTIVE' is almost the copy of 'ACTIVE' > case. Maybe we can simplify it. Yes, I keep intending to add more stats to POSTCOPY_ACTIVE, but haven't done so yet. Dave > > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK